Skip to content

Drop iOS 14 Support: Address UIButton API deprecations (#3) #21023

Merged
kean merged 2 commits intotrunkfrom
task/ios-15-fix-deprecation-warnings-io12jc912j
Jul 7, 2023
Merged

Drop iOS 14 Support: Address UIButton API deprecations (#3) #21023
kean merged 2 commits intotrunkfrom
task/ios-15-fix-deprecation-warnings-io12jc912j

Conversation

@kean
Copy link
Contributor

@kean kean commented Jul 6, 2023

Related Issue #20860

Remove some unused code with UIButton deprecations.

Test Test

  • Tap the "Create New" FAB on dashboard
  • Verify that buttons are displayed correctly

I verified it with an image diff tool. The new API works the same with the only exception how the dynamic type works: it leaves slightly less space between buttons, which I think is an improvement.

beforeafter

Regression Notes

  1. Potential unintended areas of impact: Media-related features
  2. What I did to test those areas of impact (or what existing automated tests I relied on): manual tests and unit tests
  3. What automated tests I added (or what prevented me from doing so): yes

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@kean kean added this to the Pending milestone Jul 6, 2023
@kean kean force-pushed the task/ios-15-fix-deprecation-warnings-io12jc912j branch from f4a0629 to 14da3ef Compare July 6, 2023 19:55
@kean kean requested a review from momo-ozawa July 6, 2023 19:55
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jul 6, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21023-d7dd958
Version22.7
Bundle IDorg.wordpress.alpha
Commitd7dd958
App Center BuildWPiOS - One-Offs #6242
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jul 7, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21023-d7dd958
Version22.7
Bundle IDcom.jetpack.alpha
Commitd7dd958
App Center Buildjetpack-installable-builds #5268
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean merged commit f8b3f6e into trunk Jul 7, 2023
@kean kean deleted the task/ios-15-fix-deprecation-warnings-io12jc912j branch July 7, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants