Skip to content

Remove WPImageSource usages#22297

Merged
kean merged 4 commits intotrunkfrom
task/remove-wpimagesource-usage
Jan 11, 2024
Merged

Remove WPImageSource usages#22297
kean merged 4 commits intotrunkfrom
task/remove-wpimagesource-usage

Conversation

@kean
Copy link
Contributor

@kean kean commented Dec 27, 2023

Remove WPImageSource usage from MediaExternalExporter, JetpackSocialNoConnectionView, and StatsTotalRow. The app now uses an improved ImageDownloader that has memory cache, HTTP disk cache, and supports background decompression – among other things.

To test:

MediaExternalExporter (External Images)

  • Create a new Post
  • Add "Image"
  • Select "Free Photo Library" and pick an image
  • Verify that the image got uploaded

JetpackSocialNoConnectionView

  • Verify that Jetpack connection card images get downloaded
Screenshot 2023-12-27 at 10 44 38 AM

StatsTotalRow

  • Verify that Stats / Referrer images get downloaded and displayed
Screenshot 2023-12-27 at 10 47 35 AM

Regression Notes

  1. Potential unintended areas of impact: multiple
  2. What I did to test those areas of impact (or what existing automated tests I relied on): manual
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added this to the Pending milestone Dec 27, 2023
@kean kean changed the title Remove WPImageSource Remove WPImageSource usages Dec 27, 2023
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22297-f898dec
Version23.9
Bundle IDorg.wordpress.alpha
Commitf898dec
App Center BuildWPiOS - One-Offs #8259
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22297-f898dec
Version23.9
Bundle IDcom.jetpack.alpha
Commitf898dec
App Center Buildjetpack-installable-builds #7283
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean requested a review from momo-ozawa January 9, 2024 19:55
Base automatically changed from task/add-prefetching-to-media-gallery to trunk January 10, 2024 23:06
@kean kean merged commit 811aa03 into trunk Jan 11, 2024
@kean kean deleted the task/remove-wpimagesource-usage branch January 11, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants