Merged
Conversation
This was referenced Feb 13, 2024
Contributor
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr22602-d38dea8 | |
| Version | 24.3 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | d38dea8 | |
| App Center Build | WPiOS - One-Offs #8966 |
Contributor
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr22602-d38dea8 | |
| Version | 24.3 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | d38dea8 | |
| App Center Build | jetpack-installable-builds #7996 |
13 tasks
…press-mobile/WordPress-iOS into gutenberg/support-for-videopress-v5
SiobhyB
commented
Feb 21, 2024
|
|
||
| - (BOOL)supportsVideoPressV5 | ||
| { | ||
| return self.isHostedAtWPcom || self.isAtomic || [self hasRequiredJetpackVersion:@"8.5"]; |
Contributor
Author
There was a problem hiding this comment.
See related comment on Android PR for selecting this version number: https://github.com/wordpress-mobile/WordPress-Android/pull/20181/files#r1497916911
fluiddot
approved these changes
Feb 22, 2024
RELEASE-NOTES.txt
Outdated
| 24.4 | ||
| ----- | ||
|
|
||
| * [**] Block editor: Introduce VideoPress v5 support, to fix issues using video block with dotcom and Jetpack sites [https://github.com/wordpress-mobile/gutenberg-mobile/pull/6634] |
Contributor
There was a problem hiding this comment.
Additionally, since VideoPress v5 is a Jetpack block and it won't be available in the WP app, we should consider adding the prefix [Jetpack-only].
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Related PRs
Gutenberg: RNMobile: Add new Video block capability WordPress/gutenberg#59144Gutenberg Mobile: Initial support for VideoPress v5 gutenberg-mobile#6634Jetpack: [RNMobile] Initial support for VideoPress v5 Automattic/jetpack#35637Android: Initial support for VideoPress v5 WordPress-Android#20181To Test:
Please refer to the Jetpack PR as the central place for these changes, with the most up-to-date testing instructions.
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txtif necessary.Testing Checklist: