Skip to content

Update required Xcode version to 15.4#23259

Merged
mokagio merged 6 commits intotrunkfrom
mokagio/xcode-15.4
Jun 11, 2024
Merged

Update required Xcode version to 15.4#23259
mokagio merged 6 commits intotrunkfrom
mokagio/xcode-15.4

Conversation

@mokagio
Copy link
Contributor

@mokagio mokagio commented May 27, 2024

What it says on the title. Thanks @kean for the ping about this and to @spencertransier for doing the provisioning work that made the 15.4 image available in CI.

Testing

Let's see if CI is green...

Regression Notes

N.A., in that if there are new Xcode 15.4 specific issues, we should see them locally first.

  1. Potential unintended areas of impact – N.A.
  2. What I did to test those areas of impact (or what existing automated tests I relied on) – N.A.
  3. What automated tests I added (or what prevented me from doing so) – N.A.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes. N.A.
  • I have considered adding accessibility improvements for my changes. N.A.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary. N.A.

UI changes testing checklist: Not a UI PR.

@mokagio mokagio added this to the 25.1 milestone May 27, 2024
@mokagio mokagio added the Tooling Build, Release, and Validation Tools label May 27, 2024
@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 27, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23259-9b1e734
Version25.1
Bundle IDorg.wordpress.alpha
Commit9b1e734
App Center BuildWPiOS - One-Offs #10144
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 27, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23259-9b1e734
Version25.1
Bundle IDcom.jetpack.alpha
Commit9b1e734
App Center Buildjetpack-installable-builds #9192
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@mokagio mokagio force-pushed the mokagio/xcode-15.4 branch from b6f9758 to 7eb219e Compare May 27, 2024 04:16
@kean
Copy link
Contributor

kean commented May 31, 2024

Thanks, Gio. Ready and waiting 😊

Screenshot 2024-05-31 at 12 50 44 PM

@mokagio
Copy link
Contributor Author

mokagio commented Jun 5, 2024

@kean and any other iOS developer interested in upgrading to Xcode 15.4

As you can see, this PR sets up CI to use the new Xcode image. Everything builds and runs fine except for the UI tests 😓

From the logs, it looks like they didn't run at all:

image

It's possible the issue is due to some silly mistake I made in 7eb219e when addressing the new Swift concurrency compiler error.

Unfortunately, I don't have bandwidth to look into this at the moment. I won't be able to come back here till at least Tuesday 6/11. Depending on how eager you are to run Xcode 15.4 locally and in CI, you might want to take a stab at it.

@kean
Copy link
Contributor

kean commented Jun 5, 2024

Everything builds and runs fine except for the UI tests 😓

Tested locally: builds & runs, UI test work.
Interestingly, "UI Tests (iPhone) — Passed". The only tests that failed are iPad tests.

Logs:

[23:46:14]: $ xcodebuild -showBuildSettings -workspace /opt/ci/builds/builder/automattic/wordpress-ios/WordPress.xcworkspace -scheme JetpackUITests 2>&1
[23:46:17]: Command timed out after 3 seconds on try 1 of 4, trying again with a 6 second timeout...
[23:46:23]: Command timed out after 6 seconds on try 2 of 4, trying again with a 12 second timeout...

Folks suggesting trying to increase the timeout fastlane/fastlane#20919 (comment). I'm not sure how it could help, but I'm out of idea why it works on iPhone but no iPad.

@dvdchr
Copy link
Contributor

dvdchr commented Jun 10, 2024

Hey @mokagio 👋 , I'll push the milestone to 25.2 for now as I'm starting code freeze for 25.1. Feel free to change it back to 25.1 if it's necessary for the beta!

@dvdchr dvdchr modified the milestones: 25.1, 25.2 Jun 10, 2024
@jostnes
Copy link
Contributor

jostnes commented Jun 11, 2024

👋 @mokagio, the issue seems very similar to what happened on the upgrade in WCiOS recently, the reason the tests on iPad were failing was because it couldn't find the device that was set on CI builds and used the default device instead which was iPhone SE (more context: p1717452376837839-slack-C6H8C3G23). i didn't test it, but sharing it here in case it's really the same issue

mokagio added 2 commits June 11, 2024 16:50
Could it be that the failure we are seeing in the Xcode 15.4 image are
due to which iPad it is trying to load?
@mokagio
Copy link
Contributor Author

mokagio commented Jun 11, 2024

Hey @jostnes ! Thanks for stopping by and sharing your experience.

Fun fact, I tried the Simulator destination change before reading your comment: It worked 🎉

image

Now I merged trunk into this old branch. Fingers crossed nothing changed on that end and we can move forward.

@mokagio mokagio enabled auto-merge June 11, 2024 09:47
This reverts commit 74f2277 as it
proved insufficient to fix the issue.
Copy link
Contributor

@twstokes twstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to be all ✅ so approving. Thanks @mokagio!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tooling Build, Release, and Validation Tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants