Conversation
7e9a7fd to
a560a86
Compare
Contributor
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23396-22c4c39 | |
| Version | 25.1 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 22c4c39 | |
| App Center Build | WPiOS - One-Offs #10263 |
a560a86 to
3ca8096
Compare
Contributor
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23396-22c4c39 | |
| Version | 25.1 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 22c4c39 | |
| App Center Build | jetpack-installable-builds #9310 |
3ca8096 to
f0b2ab3
Compare
jkmassel
approved these changes
Jul 2, 2024
|
Hi @kean, For example, I have a Figma design, and I download some icons in 3 different formats: PNG, SVG, and PDF.
After some measures, using 3 PNGs has a smaller Assets.car file size compared to using SVG and PDF. My question is: How did you generate the SVG that is so small (only 2KB) compared to 3 PNGs and 1 PDF format? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



I made a mistake in the previous PR where I added compressed
JPBackgroundpngs but completely forgot about Xcode compression – it was inflating them back to around 1.9 MBs. I don't think there is any good way of disabling it, so I re-implemented Jeremy's solution from #23261 since it's an even better option, reducing the size down to 35 KB as .svg files gets included in the .car bundle as is.The new size of the compressed universal .ipa is 116.2 MB down from 122.3 MB (-6.1 MB).
Compressing other assets manually is pointless because Xcode will re-compress them again at build time, leading to a loss in quality unless we disable compression globally and manage it fully ourselves.
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: