Replace WPImageViewController with LightboxViewController#23922
Merged
kean merged 18 commits intochristmas-feature-branchfrom Dec 24, 2024
Merged
Replace WPImageViewController with LightboxViewController#23922kean merged 18 commits intochristmas-feature-branchfrom
kean merged 18 commits intochristmas-feature-branchfrom
Conversation
Collaborator
Generated by 🚫 Danger |
kean
commented
Dec 24, 2024
| } | ||
|
|
||
| override func hitTest(_ point: CGPoint, with event: UIEvent?) -> UIView? { | ||
| if configuration.passTouchesToSuperview && self.bounds.contains(point) { |
Contributor
Author
There was a problem hiding this comment.
This was needed to make it work in WPRichTextImage (UIControl, needed to pass gestures to the superview)
Contributor
There was a problem hiding this comment.
Would disabling user interaction on AsyncImageView achieve the same thing?
Contributor
Author
There was a problem hiding this comment.
That was my initial attempt, but for some reason it didn't work. It's probably because of UIControl or gesture recognizers in a text view (it's an attachment here) or something else. I'm planning to remove WPRichTextImage as part of the upcoming project of the Reader Comments rework, so I dropped a note to remove passTouchesToSuperview when it's no longer used.
kean
commented
Dec 24, 2024
| addSubview(imageView) | ||
| } | ||
|
|
||
| required public init?(coder aDecoder: NSCoder) { |
Contributor
Author
There was a problem hiding this comment.
The encoding was not used anywhere.
Contributor
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23922-9e82544 | |
| Version | 25.6 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 9e82544 | |
| App Center Build | WPiOS - One-Offs #11225 |
Contributor
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23922-9e82544 | |
| Version | 25.6 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 9e82544 | |
| App Center Build | jetpack-installable-builds #10263 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
LightboxViewControllerto replaceWPImageViewController(Objective-C). The new screen usesImageDownloaderand also supports the zoom transitions introduced in iOS 18.media-after.mov
Here's how it used to look: before.
Changes
LightboxViewController(currently only supports one item at a time like the previous ViewController did)WPRichTextImageto useAsyncImageView(tested manually)PostFeaturedImageCellfrom Objective-C to Swift and removeImageLoaderusagesFeaturedImageViewController(Objective-C) and use natively provided toolbar insteadWPImageViewControllerRegression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: