Add ImageSize

[kean]

Adds ImageSize to clarify that ImageDownloader uses pixels as a parameter and make sure you can't blindly pass something like view.frame.size to in, which is incorrect.

This PR also adds ImageRequest support to AsyncImageView.

Regression Notes

1. Potential unintended areas of impact

2. What I did to test those areas of impact (or what existing automated tests I relied on)

3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

• WordPress.com sites and self-hosted Jetpack sites.
• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• VoiceOver.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• iPhone and iPad.
• Multi-tasking: Split view and Slide over. (iPad)

[dangermattic]

	1 Error
🚫	PR requires at least one label.

	1 Warning
⚠️	View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr23929-3b036a0
	Version	25.6
	Bundle ID	org.wordpress.alpha
	Commit	3b036a0
	App Center Build	WPiOS - One-Offs #11237

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr23929-3b036a0
	Version	25.6
	Bundle ID	com.jetpack.alpha
	Commit	3b036a0
	App Center Build	jetpack-installable-builds #10275

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[crazytonyli]

Should these properties be Int? There is no decimal pixel, right?

[kean]

Updated in the upcoming PR.

[crazytonyli]

What do you thinking changing this API to init(pixels:)? IMHO, the name init(pixels:) matches the init(scaling...) ones to make it a bit clearer that this API accepts pixels sizes, and the "scaling" ones accept points sizes.

[kean]

That makes sense; updating in the upcoming PR.

[crazytonyli]

Using UITraitCollection.current.displayScale as the default scale (even though that may be the correct value 90% of the time) may lead to misuse. What do you think about adding a non-optional scale argument here? Maybe, even include "points" in the name: ImageSize(points:scale:)?

Of course, you can add some convenient methods on top of it, like ImageSize(points: CGSize, in: UITraitCollection), to make it easier to use the app wide scale easier: ImageSize(points: ..., in: .current)

[kean]

Yeah, you can misuse current. I'm not entirely sure I understand how it works. I'm chasing it to the following:

    /// A convenience initializer that creates `ImageSize` with the given size
    /// in **points** scaled for the given view.
    @MainActor
    public init(scaling size: CGSize, in view: UIView) {
        self.init(scaling: size, scale: view.traitCollection.displayScale)
    }

    /// Initializes `ImageSize` with the given size in **points** scaled for the
    /// current trait collection display scale.
    public init(scaling size: CGSize, scale: CGFloat) {
        self.init(pixels: size.scaled(by: max(1, scale)))
    }

• It doesn't use current anymore
• It enforces you to either provide a view (always has a valid trait collection) or a scale exclicitly
• Add max(1, scale) just in case
• Add documentation (**points**)