Fix transitions in Blogging Reminders flow, improve accessibility, add close buttons#23931
Merged
kean merged 15 commits intochristmas-feature-branchfrom Dec 31, 2024
Merged
Conversation
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23931-84ac565 | |
| Version | 25.6 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 84ac565 | |
| App Center Build | WPiOS - One-Offs #11240 |
Contributor
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23931-84ac565 | |
| Version | 25.6 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 84ac565 | |
| App Center Build | jetpack-installable-builds #10278 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Changes:
BottomSheetViewControllerusage fromBloggingRemindersflow. It now uses modern deters for the intro screen and standard modal flows for the rest of the flow, so there is no jumping.FancyButtonusagesUIButton.Configurationbased .primary button styleSpacerView,SeparatorView,BottomToolbarViewLightNavigationControllerAccessibility
The intro screen can now accommodate larger font sizes. It also has a "close" button, so does the "Settings" screen.
Screen.Recording.2024-12-31.at.2.16.30.PM.mov
Animations
It also no longer has these broken transitions (it just shows a standard form instead)
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-12-30.at.18.14.26.mp4
To test:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: