Skip to content

Integrate zoom transitions in Reader#23947

Merged
kean merged 2 commits intochristmas-feature-branchfrom
task/zoom-transitions-reader-ipad
Jan 6, 2025
Merged

Integrate zoom transitions in Reader#23947
kean merged 2 commits intochristmas-feature-branchfrom
task/zoom-transitions-reader-ipad

Conversation

@kean
Copy link
Contributor

@kean kean commented Jan 6, 2025

after-zoom-reader.mp4

The previous transitions used an awkward gray selected style, which is now gone.

before-zoom-reader.mp4

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the Reader label Jan 6, 2025
@kean kean added this to the 25.7 milestone Jan 6, 2025
@kean kean merged commit e6f37bd into christmas-feature-branch Jan 6, 2025
@kean kean deleted the task/zoom-transitions-reader-ipad branch January 6, 2025 19:32
@kean kean mentioned this pull request Jan 6, 2025
14 tasks
@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23947-7584f56
Version25.6
Bundle IDcom.jetpack.alpha
Commit7584f56
App Center Buildjetpack-installable-builds #10315
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23947-7584f56
Version25.6
Bundle IDorg.wordpress.alpha
Commit7584f56
App Center BuildWPiOS - One-Offs #11278
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@crazytonyli
Copy link
Contributor

IMHO, push transition works better in the context of a list and details screen. The "<" back button also indicates a pop transition. An "x" dismiss button might be more suitable for a zoom-out transition.

@kean
Copy link
Contributor Author

kean commented Jan 13, 2025

Apple uses this transition in iOS 18 pretty often for "push" navigations with a back button. I think I agree that it still feels a little bit off here. I think I mainly prefer the new transition because it allows you to dismiss a post quickly with a swipe. With a traditional push, you have to tap "back" on iPad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants