Skip to content

Experiment: SwiftLint via isolated CocoaPods install#23998

Closed
mokagio wants to merge 2 commits intomokagio/remove-cocoapods-christmast-branchfrom
mokagio/swiftlint-via-cp
Closed

Experiment: SwiftLint via isolated CocoaPods install#23998
mokagio wants to merge 2 commits intomokagio/remove-cocoapods-christmast-branchfrom
mokagio/swiftlint-via-cp

Conversation

@mokagio
Copy link
Contributor

@mokagio mokagio commented Jan 21, 2025

Fixes #

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@dangermattic
Copy link
Collaborator

dangermattic commented Jan 21, 2025

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@mokagio mokagio changed the base branch from trunk to mokagio/remove-cocoapods-christmast-branch January 21, 2025 21:31
@mokagio mokagio changed the title Mokagio/swiftlint via cp Experiment: SwiftLint via isolated CocoaPods install Jan 22, 2025
@mokagio mokagio self-assigned this Jan 22, 2025
@mokagio mokagio added this to the Pending milestone Jan 22, 2025
@mokagio
Copy link
Contributor Author

mokagio commented Jan 30, 2025

Closing as an experiment that has run its course

@mokagio mokagio closed this Jan 30, 2025
@mokagio mokagio deleted the mokagio/swiftlint-via-cp branch January 30, 2025 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants