Skip to content

Bypass SwiftLint using ACTION instead of CONFIGURATION#24094

Merged
mokagio merged 2 commits intotrunkfrom
mokagio/skip-swiftlint-archive-only
Feb 19, 2025
Merged

Bypass SwiftLint using ACTION instead of CONFIGURATION#24094
mokagio merged 2 commits intotrunkfrom
mokagio/skip-swiftlint-archive-only

Conversation

@mokagio
Copy link
Contributor

@mokagio mokagio commented Feb 19, 2025

Follows up on
#23996 (comment)

Makes the logic more precise, given the error occurs when archiving.

To test: One can only test this locally because we bypass the SwiftLint build phase in CI in favor of the dedicated linter.

Here are screenshots from my local machine:

image _A successful build, including SwiftLint_ image

Important

One of the prototype builds failed, but the error is about is at the AppCenter level

image

Regression Notes

  1. Potential unintended areas of impact – N.A.
  2. What I did to test those areas of impact (or what existing automated tests I relied on) – N.A.
  3. What automated tests I added (or what prevented me from doing so) – N.A.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes. N.A.
  • I have considered adding accessibility improvements for my changes. N.A.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary. N.A.

UI changes testing checklist: Not a UI PR.

Co-authored-by: Olivier Halligon <olivier.halligon@automattic.com>

Follows up on
#23996 (comment)

Makes the logic more precise, given the error occurs when archiving.
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 19, 2025

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr24094-32ed02f
Version25.7.1
Bundle IDorg.wordpress.alpha
Commit32ed02f
App Center BuildWPiOS - One-Offs #11517
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 19, 2025

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr24094-32ed02f
Version25.7.1
Bundle IDcom.jetpack.alpha
Commit32ed02f
App Center Buildjetpack-installable-builds #10549
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@mokagio mokagio marked this pull request as ready for review February 19, 2025 06:40
@mokagio mokagio added this to the 25.9 milestone Feb 19, 2025
@mokagio mokagio added the Tooling Build, Release, and Validation Tools label Feb 19, 2025
@mokagio mokagio self-assigned this Feb 19, 2025
@mokagio mokagio requested a review from a team February 19, 2025 06:45
@mokagio mokagio enabled auto-merge February 19, 2025 06:45
@mokagio mokagio added this pull request to the merge queue Feb 19, 2025
Merged via the queue into trunk with commit 28c270c Feb 19, 2025
27 checks passed
@mokagio mokagio deleted the mokagio/skip-swiftlint-archive-only branch February 19, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tooling Build, Release, and Validation Tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants