Conversation
Collaborator
kean
force-pushed
the
task/move-tracks-info
branch
from
4738485 to
0446e18
Compare
kean
commented
Mar 19, 2025
| <key>WPEventNamePrefix</key> | ||
| <string>jpios</string> | ||
| <key>WPExplatPlatform</key> | ||
| <string>wpios</string> |
Contributor
Author
There was a problem hiding this comment.
Matches what was defined in WordPress/Jetpack/AppConstants.swift
@objc static let eventNamePrefix = "jpios"
@objc static let explatPlatform = "wpios"
Contributor
There was a problem hiding this comment.
It's curios that it was defined like that though... 🤔
But apparently, it was intentional: #20607
Contributor
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr24253-e63f928 | |
| Version | 25.8 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | e63f928 | |
| App Center Build | WPiOS - One-Offs #11722 |
Contributor
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr24253-e63f928 | |
| Version | 25.8 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | e63f928 | |
| App Center Build | jetpack-installable-builds #10750 |
kean
commented
Mar 19, 2025
| } | ||
|
|
||
| // TODO: remove when WPAppAnalyticsTests get rewritten, preferably in Swift | ||
| @objc final class WPAnalyticsTesting { |
Contributor
Author
There was a problem hiding this comment.
I didn't want to mess with the Objective-C code too much 😞
It would make sense to refactor it together with a Swift rewrite.
kean
force-pushed
the
task/move-tracks-info
branch
from
3efbe6f to
9513bb2
Compare
kean
force-pushed
the
task/move-tracks-info
branch
from
9513bb2 to
e63f928
Compare
mokagio
approved these changes
Mar 19, 2025
| <key>WPEventNamePrefix</key> | ||
| <string>jpios</string> | ||
| <key>WPExplatPlatform</key> | ||
| <string>wpios</string> |
Contributor
There was a problem hiding this comment.
It's curios that it was defined like that though... 🤔
But apparently, it was intentional: #20607
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move to
BuildSettings. Remove duplication (TracksConfiguration.swiftfor widgets andAppConstantsfor apps).To test:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: