Merged
Conversation
The method comes from an old Alamofire version. Since its implementation, `URL(string:)` stopped failing on "invalid" strings such as "invalid-url". Between the different behavior and the cost of an additional dependency, the value of using that method is marginal at best.
…age` The method comes from an old Alamofire version. Since its implementation, `URL(string:)` stopped failing on "invalid" strings such as "invalid-url". Between the different behavior and the cost of an additional dependency, the value of using that method is marginal at best.
`asURL()` comes from an old Alamofire version. Since its implementation, `URL(string:)` stopped failing on "invalid" strings such as "invalid-url". Between the different behavior and the cost of an additional dependency, the value of using that method is marginal at best. But aside from that, Swift now offers direct `URL` decoding, so we don't need to jump through any hoop. And notice that `StockPhotosMedia` has tests that validate the JSON decoding.
Collaborator
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 26827 | |
| Version | PR #24350 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | d923f1a | |
| Installation URL | 7vtoi2o2nq3t0 |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 26827 | |
| Version | PR #24350 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | d923f1a | |
| Installation URL | 3lbapb4g7jfvo |
kean
approved these changes
Mar 28, 2025
| } else if let apiBase = apiBase(blog: blog), | ||
| let loginURL = try? blog.loginUrl().asURL(), | ||
| let adminURL = try? blog.adminUrl(withPath: "").asURL(), | ||
| let loginURL = URL(string: blog.loginUrl()), |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up to #24333, part of #24165.
The method comes from an old Alamofire version. Since its implementation,
URL(string:)stopped failing on "invalid" strings such as "invalid-url". Between the different behavior and the cost of an additional dependency, the value of using that method is marginal at best.Notice that the app still has an
asURL()implementation, but that's part of theParsedUrlcustom type.