Skip to content

Fix how local Modules are added#24511

Merged
kean merged 1 commit intotrunkfrom
task/re-add-local-modules
May 1, 2025
Merged

Fix how local Modules are added#24511
kean merged 1 commit intotrunkfrom
task/re-add-local-modules

Conversation

@kean
Copy link
Contributor

@kean kean commented Apr 30, 2025

Timeline

  • When Modules were initially created, they were added to the project by drag-n-dropping them to the Xcode Project Navigator (assumption).
  • When I explored SwiftLint Build Tool Plugin, I used the new workflow for adding local packages (Packages / Add / Add Local...). It was required to get Xcode to see the plugins.

As a result, Xcode now thinks there are two sets of the same local packages:

Screenshot 2025-04-30 at 2 33 05 PM

Fix

In order to fix it, I removed the packages that were drag-n-dropped to the project. The local modules are now displayed automatically under "Package Dependencies". Xcode puts them at the top.

Screenshot 2025-04-30 at 2 35 03 PM Screenshot 2025-04-30 at 2 35 06 PM

@kean kean added the General label Apr 30, 2025
@kean kean added this to the 25.9 milestone Apr 30, 2025
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 25.9. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@kean kean requested a review from mokagio April 30, 2025 18:51
@sonarqubecloud
Copy link

@wpmobilebot
Copy link
Contributor

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number27559
VersionPR #24511
Bundle IDorg.wordpress.alpha
Commit963919c
Installation URL6f1v00mi4f4tg
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number27559
VersionPR #24511
Bundle IDcom.jetpack.alpha
Commit963919c
Installation URL66rm85cuqbomo
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@kean kean enabled auto-merge April 30, 2025 19:05
Copy link
Contributor

@mokagio mokagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thank you for documenting the different approaches.

@kean kean added this pull request to the merge queue May 1, 2025
Merged via the queue into trunk with commit 0112a1d May 1, 2025
34 of 36 checks passed
@kean kean deleted the task/re-add-local-modules branch May 1, 2025 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants