Implement Jetpack Activity Logs screen (list)#24596
Merged
kean merged 1 commit intofeature/jetpack-activity-logsfrom Jun 19, 2025
Merged
Implement Jetpack Activity Logs screen (list)#24596kean merged 1 commit intofeature/jetpack-activity-logsfrom
kean merged 1 commit intofeature/jetpack-activity-logsfrom
Conversation
Collaborator
Generated by 🚫 Danger |
kean
force-pushed
the
task/activity-logs-p1
branch
from
6ae9979 to
c1222ae
Compare
kean
commented
Jun 18, 2025
| @@ -0,0 +1,17 @@ | |||
| { | |||
| "permissions": { | |||
Contributor
Author
There was a problem hiding this comment.
These are safe readonly tools (recommend by Boris).
|
|
||
| /// A generic search view that works with DataViewPaginatedResponse. | ||
| /// Provides search functionality with debouncing, loading states, and error handling. | ||
| public struct DataViewSearchView<Response: DataViewPaginatedResponseProtocol, Content: View>: View { |
Contributor
Author
There was a problem hiding this comment.
Extracted from SubscribersView.
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 27885 | |
| Version | PR #24596 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 96f9cfd | |
| Installation URL | 1f9spfjrk8cb0 |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 27885 | |
| Version | PR #24596 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 96f9cfd | |
| Installation URL | 6dpqpu1sv1qd8 |
kean
force-pushed
the
task/activity-logs-p1
branch
from
c1222ae to
96f9cfd
Compare
|
Base automatically changed from
task/activity-logs-swiftui
to
feature/jetpack-activity-logs
June 19, 2025 12:19
crazytonyli
reviewed
Jun 22, 2025
| let content: (Response) -> Content | ||
|
|
||
| /// Delay in milliseconds before executing search (default: 500ms) | ||
| let debounceDelay: UInt64 |
Contributor
There was a problem hiding this comment.
Nitpick: debounceDelayInMilliseconds (or use a type like Duration) to be extra clear about the time unit.
Contributor
Author
There was a problem hiding this comment.
I switched to the Duration type – much clearer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear: https://linear.app/a8c/project/apple-dataview-in-activity-logs-747664472a7e/overview
This PR adds Jetpack Activity Logs implemented using SwiftUI.
New Components
DataViewSearchView: Generic reusable search component for paginated listsActivityLogsMenu: Filter menu with date pickers and activity type selectionActivityTypeSelectionView: Multi-select view for filtering by activity typesSimulator.Screen.Recording.-.iPhone.16.Pro.-.2025-06-18.at.15.25.31.mov
Testing