Add ActivityLogsDetailsView#24599
Merged
kean merged 10 commits intofeature/jetpack-activity-logsfrom Jun 19, 2025
Merged
Conversation
- Implement modern SwiftUI version of Activity Detail screen - Use card-based design system matching SubscriberDetailsView - Add proper localization with NSLocalizedString and reverse-DNS keys - Use WPStyleGuide for consistent icon and color handling - Include activity stats visualization for backup events - Add restore and download backup actions with confirmation dialogs - Integrate with existing Activity model and RewindStatus - Update ContentView with navigation links for testing - Configure MiniatureApp with proper navigation and theming
- Create Activity+Icon.swift with gridiconType, icon, and statusColor properties - Update all references to use new Activity extension methods - Deprecate old WPStyleGuide methods with proper deprecation messages - Remove stringToGridiconTypeMapping from WPStyleGuide - Fix linter warnings for trailing whitespace and shorthand optional binding
- Remove rewindStatus parameter from ActivityLogDetailsView initializer - Remove rewindStatus checks in ActivityActionsCard - Update preview providers to not pass rewindStatus - Update ContentView to not create mock RewindStatus instances - Remove warning card for multisite installations - Simplify restore button enable/disable logic
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 27893 | |
| Version | PR #24599 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | c02e30c | |
| Installation URL | 77khon8dqk6g8 |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 27893 | |
| Version | PR #24599 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | c02e30c | |
| Installation URL | 57bhq931ulm80 |
kean
commented
Jun 19, 2025
| private extension ProcessInfo { | ||
| var isXcodePreview: Bool { | ||
| environment["XCODE_RUNNING_FOR_PREVIEWS"] == "1" | ||
| environment["XCODE_RUNNING_FOR_PREVIEWS"] == "1" || environment["WP_USE_PREVIEW_ENVIRONMENT"] == "1" |
Contributor
Author
There was a problem hiding this comment.
I didn't want to add Info.plist with all the setting to the Miniature app, so I added a way to use the preview settings.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds initial
ActivityLogsDetailsViewimplementation to replaceActivityDetailViewController. The new screen if SwiftUI-based and uses the refreshed design to match the list and the WordPress Design System.