Activity Logs: Code Removal – Part 6#24609
Merged
kean merged 4 commits intofeature/jetpack-activity-logsfrom Jun 20, 2025
Merged
Activity Logs: Code Removal – Part 6#24609kean merged 4 commits intofeature/jetpack-activity-logsfrom
kean merged 4 commits intofeature/jetpack-activity-logsfrom
Conversation
Collaborator
Generated by 🚫 Danger |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes
ActivityStore. There was only one complication:ActivityLogDetailsCoordinatorwas still relying on the latest rewind status from the store. I updated the app to fetch it when you tap "Restore Backup", so you get the latest state. I verified (with mocked data), that the flow works.I made no changes to the "Restore Backup" flow itself during this project, so it doesn't need to be tested. Fortunately, it never relied on
ActivityStoreand has its own polling mechanism for the rewind status.Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-06-20.at.11.57.26.mov