Conversation
|
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 29693 | |
| Version | PR #24708 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | ab0d51f | |
| Installation URL | 3qnehuk8nle40 |
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 29693 | |
| Version | PR #24708 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | ab0d51f | |
| Installation URL | 16g4do00ur3d8 |
d55130a to
b435245
Compare
b435245 to
449e825
Compare
055080b to
c078eca
Compare
c078eca to
cdd2ba7
Compare
| case .playground: menu.makeImagePlaygroundAction(delegate: controller) | ||
| case .siteMedia: menu.makeSiteMediaAction(blog: blog, delegate: controller) | ||
| case .photos: menu.makePhotosAction(delegate: controller) | ||
| case .freePhotos: menu.makeStockPhotos(blog: blog, delegate: controller) |
There was a problem hiding this comment.
All the media providers succeeded in my testing accept for this "Free photos" provider. When selecting an image, the request always resulted in a 500 response.
I copied each request as a curl command from Proxyman. When comparing the commands, I noted that the GIF provider included the .gif file ending; contrastingly, the "Free photos" provider lacked a file ending. When I manually added a .jpg file ending, the request succeeded.
Do you experience this? What might causing these 500 responses?
|
I encountered a crash with Patterns on WPCOM Simple sites. I fixed this in wordpress-mobile/GutenbergKit#223. Waiting for approval of that before we move forward merging this PR. |
dcalhoun
left a comment
There was a problem hiding this comment.
Approving. We need to address the 500 responses when using the Free photos media provider, but the native block inserter is behind a feature flag anyways.
|





Integrates new native inserter for Gutenberg.
Testing Instructions
Important: enable "Native Inserter" FF.
Known Issues
The routine that handles the selection needs to updated to support using site media without uploading it.
Screenshots