Stats Review: Add StatsService (P8)#24720
Closed
kean wants to merge 1 commit intoreview/contry-map-viewfrom
Closed
Stats Review: Add StatsService (P8)#24720kean wants to merge 1 commit intoreview/contry-map-viewfrom
kean wants to merge 1 commit intoreview/contry-map-viewfrom
Conversation
Collaborator
Generated by 🚫 Danger |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
StatsServiceas an adapter forWordPressKit. It is a little bit messy because of the API design.Notes:
WordPressKitin the local device time zone to the site time zonegetTopListDatadoesn't actually support loading separate metrics (SiteMetric) yet, but the mock store does – hope to add it in the future