Stats Review: Add TopListItemView (P9)#24721
Closed
kean wants to merge 1 commit intoreview/stats-servicefrom
Closed
Stats Review: Add TopListItemView (P9)#24721kean wants to merge 1 commit intoreview/stats-servicefrom
kean wants to merge 1 commit intoreview/stats-servicefrom
Conversation
kean
changed the title
Collaborator
Generated by 🚫 Danger |
|
crazytonyli
reviewed
Aug 6, 2025
| // MARK: - Environment Key | ||
|
|
||
| private struct StatsContextKey: EnvironmentKey { | ||
| static let defaultValue = StatsContext.demo |
Contributor
There was a problem hiding this comment.
It seems dangerous to use a mock value as the default value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds individual rows to be shown in the future
TopListCard. I also includedStatsContextandStatsRouterin this PR – these are the only two types that are injected into the module from the app and manage the environment (site time zone) and the external navigation (e.g. opening likes list hosted by the app).