Stats Review: Add ChartCard, TopListCard, StandaloneChartView (P12)#24724
Closed
kean wants to merge 1 commit intoreview/add-chartsfrom
Closed
Stats Review: Add ChartCard, TopListCard, StandaloneChartView (P12)#24724kean wants to merge 1 commit intoreview/add-chartsfrom
kean wants to merge 1 commit intoreview/add-chartsfrom
Conversation
Collaborator
Generated by 🚫 Danger |
|
crazytonyli
reviewed
Aug 6, 2025
| isStale = false | ||
| chartData = data | ||
| } catch is CancellationError { | ||
| return |
Contributor
There was a problem hiding this comment.
I think you'd want to set the isLoading = false here. Or, you could add defer { isLoading = false } to the top of the function, and don't need to worry about early returns.
Contributor
Author
There was a problem hiding this comment.
When the view model cancels the request, it effectively unsubscribes from the previous request and starts a new one – there is no need to handle the termination of the cancelled request.
| cachedCountriesMapData = nil | ||
| } | ||
| } catch is CancellationError { | ||
| return |
Contributor
There was a problem hiding this comment.
Potentially missed isLoading = false here too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the actual cards. The cards load the data and manage its presentation. The more challenging bit was to get it to stagger the reloads in the case the user taps quickly on "backward" or "forward" button.
I put both charts in the same PR as there are many similarities between them.
This PR also contains
StandaloneChartCardwhich is used on thePostStatsView. This component could be improved as there is likely something to reuse with the other cards.I also included
TopListScreenViewthat opened when you tap "Show All" on the "Top List" card: