Skip to content

Save new values even if options is nil#25266

Merged
crazytonyli merged 2 commits intotrunkfrom
bugfix/set-empty-options
Feb 19, 2026
Merged

Save new values even if options is nil#25266
crazytonyli merged 2 commits intotrunkfrom
bugfix/set-empty-options

Conversation

@crazytonyli
Copy link
Contributor

Description

We store "is XMLRPC disabled" value to Blog.options, which may get lost if the options is nil or empty.

@crazytonyli crazytonyli added this to the 26.7 milestone Feb 18, 2026
@crazytonyli crazytonyli requested a review from kean February 18, 2026 01:32
@dangermattic
Copy link
Collaborator

dangermattic commented Feb 18, 2026

1 Warning
⚠️ This PR is assigned to the milestone 26.7. This milestone is due in less than 4 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 18, 2026

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number31005
VersionPR #25266
Bundle IDorg.wordpress.alpha
Commit6317fc4
Installation URL69apoabbodan0
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 18, 2026

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number31005
VersionPR #25266
Bundle IDcom.jetpack.alpha
Commit6317fc4
Installation URL169l38dpoi69g
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 18, 2026

🤖 Build Failure Analysis

This build has failures. Claude has analyzed them - check the build annotations for details.

Copy link
Contributor

@kean kean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also noticed it today in my work and Claude flagged it. The changes seems reasonable, but I'm not quite sure if its' a bug or intended.

@crazytonyli
Copy link
Contributor Author

@kean I had looked and traced the changes to #14169. I think it'd be okay to allow updating nil options.

@sonarqubecloud
Copy link

@crazytonyli crazytonyli added this pull request to the merge queue Feb 19, 2026
Merged via the queue into trunk with commit 531af17 Feb 19, 2026
27 of 32 checks passed
@crazytonyli crazytonyli deleted the bugfix/set-empty-options branch February 19, 2026 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants