Skip to content

Support most Post Settings on custom posts#25274

Open
crazytonyli wants to merge 2 commits intotrunkfrom
task/post-settings-terms
Open

Support most Post Settings on custom posts#25274
crazytonyli wants to merge 2 commits intotrunkfrom
task/post-settings-terms

Conversation

@crazytonyli
Copy link
Contributor

@crazytonyli crazytonyli commented Feb 20, 2026 •
edited
Loading

Description

Here are the main changes in this PR:

  1. You can now add a new post. It reuses the same FAB design in the regular posts.
  2. PostTagsView is refactored to support returning selected tag/term id and name. Previously, it's just name. We need this change because the core REST API wants id.
  3. The Post Settings are mostly implemented on custom posts. This requires most testing though, because there are many different kinds of custom posts, and some Post Settings may not supported on some custom post types.

Test Instructions

  • Try Post Settings on custom posts
  • Regression tests on the regular posts screen

@dangermattic
Copy link
Collaborator

dangermattic commented Feb 20, 2026 •
edited
Loading

2 Warnings
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 20, 2026 •
edited
Loading

🤖 Build Failure Analysis

This build has failures. Claude has analyzed them - check the build annotations for details.

@crazytonyli crazytonyli force-pushed the task/post-settings-refactor branch from c482a6f to 07358d1 Compare February 22, 2026 05:45
@crazytonyli crazytonyli mentioned this pull request Feb 22, 2026
Merged
@crazytonyli crazytonyli force-pushed the task/post-settings-terms branch from 3176a05 to 404d35a Compare February 23, 2026 07:48
Base automatically changed from task/post-settings-refactor to trunk February 24, 2026 00:02
@crazytonyli crazytonyli force-pushed the task/post-settings-terms branch 2 times, most recently from 176d0cd to dbe79cb Compare February 24, 2026 06:24
@crazytonyli crazytonyli force-pushed the task/post-settings-terms branch from dbe79cb to ed4b166 Compare February 26, 2026 02:06
@crazytonyli crazytonyli changed the title Support taxonomy terms in custom post Post Settings Support most Post Settings on custom posts Feb 26, 2026
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 26, 2026 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number31163
VersionPR #25274
Bundle IDorg.wordpress.alpha
Commit4eebb1f
Installation URL495g57seovc5o
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 26, 2026 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number31163
VersionPR #25274
Bundle IDcom.jetpack.alpha
Commit4eebb1f
Installation URL65p6gudnpeplg
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@crazytonyli crazytonyli force-pushed the task/post-settings-terms branch from ed4b166 to 4eebb1f Compare February 26, 2026 03:40
@crazytonyli crazytonyli requested a review from kean February 26, 2026 03:40
@crazytonyli crazytonyli added this to the 26.8 milestone Feb 26, 2026
@crazytonyli crazytonyli marked this pull request as ready for review February 26, 2026 03:40
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 26, 2026

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
4.9% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kean kean Awaiting requested review from kean

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Custom Post Types

Projects

None yet

Milestone

26.8

Development

Successfully merging this pull request may close these issues.

3 participants

@crazytonyli @dangermattic @wpmobilebot