Conversation
3614546 to
829e5d9
Compare
829e5d9 to
df9e95b
Compare
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 31150 | |
| Version | PR #25303 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | ba94b4d | |
| Installation URL | 4b6l5sfb2ds3o |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 31150 | |
| Version | PR #25303 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | ba94b4d | |
| Installation URL | 47d7a95sjl600 |
Contributor
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
Collaborator
Generated by 🚫 Danger |
|
jkmassel
approved these changes
Feb 25, 2026
Contributor
jkmassel
left a comment
There was a problem hiding this comment.
Looks ok to me, pretty mechanical changes.
Claude suggested some more test coverage:
**Suggestion: consider adding tests for the remaining untested public API surface (all pre-existing gaps, not regressions from this PR):**
- `willAttemptToUploadLater()` — returns `true` when failure count < `maxAutoUploadFailureCount`, `false` when >=
- `canRetry` — `true` when `absoluteLocalURL` is set, `false` when nil
- `link` — constructs `"{siteURL}/?p={mediaID}"`, returns `""` when blog URL or mediaID is nil
- `remoteStatus` — round-trip through `remoteStatusNumber` to `MediaRemoteStatus` enum
- `absoluteLocalURL` setter with `nil` — verifies setting to nil clears `localURL`
- `fixLocalMediaURLs` with nil content — exercises the `guard var content` early-return path
- `fixLocalMediaURLs` skips remote media — explicitly verifies that the `guard !media.hasRemote` path prevents URL rewriting for uploaded media (currently only tested indirectly via regex not matching `https://`)
I can see the benefit to these, but up to you.
| import WordPressShared | ||
|
|
||
| extension AbstractPost { | ||
| /// When updating the app through the App Store or installing a new version |
Contributor
There was a problem hiding this comment.
This makes sense for absolute paths, but why would we store everything relevant to the documents directory? 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Closes #25303
The changes are covered by the extended unit test suite introduced in #25287. I also manually tested it, including the more obscure scenarios that require persisting an error, etc.