Open
Conversation
Collaborator
Generated by 🚫 Danger |
kean
changed the title
kean
force-pushed
the
task/reduce-objc-usage
branch
from
af6cc74 to
f37e527
Compare
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 31147 | |
| Version | PR #25305 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 01de02c | |
| Installation URL | 4notma9u7jc90 |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 31147 | |
| Version | PR #25305 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 01de02c | |
| Installation URL | 2h51m1e6ho9h8 |
kean
force-pushed
the
task/reduce-objc-usage
branch
from
f37e527 to
154bcc2
Compare
kean
force-pushed
the
task/reduce-objc-usage
branch
from
154bcc2 to
01de02c
Compare
|
Contributor
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
jkmassel
approved these changes
Feb 25, 2026
Contributor
jkmassel
left a comment
jkmassel
left a comment
There was a problem hiding this comment.
Looks good, just one nit.
|
|
||
| @testable import WordPressData | ||
|
|
||
| struct CoreDataMigrationTests { |
Contributor
There was a problem hiding this comment.
Should this be @MainActor like the other test suites?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... and convert to Swift Testing. With the exception of
ContextManagerTestswhere automatic conversion failed due to the complexity of the tests, but I did end up removing theNimbledependency.