Reader second pass: detail view redesign, refactoring, and improvement#716
Merged
mikejohnstn merged 44 commits intodevelopfrom Dec 6, 2013
Merged
Reader second pass: detail view redesign, refactoring, and improvement#716mikejohnstn merged 44 commits intodevelopfrom
mikejohnstn merged 44 commits intodevelopfrom
Conversation
- Moved the view hierarchy and layout logic to ReaderPostView - Gutted ReaderPostTableViewCell and made it use ReaderPostView instead
Conflicts: WordPress/Classes/ReaderPostDetailView.m WordPress/Classes/ReaderPostDetailViewController.h WordPress/Classes/ReaderPostDetailViewController.m WordPress/Classes/ReaderPostTableViewCell.m WordPress/WordPress.xcodeproj/project.pbxproj
…text merges (for now)
Conflicts: WordPress/Classes/ReaderPostsViewController.m WordPress/WordPress.xcodeproj/project.pbxproj
Contributor
Author
There was a problem hiding this comment.
These keyboard size adjustment methods are crufty. Once we move to translucent bars throughout the app, we should do a full pass and purge as many of these as possible.
Contributor
Author
There was a problem hiding this comment.
Pretty much all of this code was moved from elsewhere.
Contributor
|
This looks really great on the device, @mikejohnstn. Let me know if you want to discuss the code feedback I gave. |
Conflicts: WordPress/Classes/ReaderPostsViewController.m WordPress/WordPress.xcodeproj/project.pbxproj
Contributor
|
|
sir!
mikejohnstn
added a commit
that referenced
this pull request
Dec 6, 2013
Reader second pass: detail view redesign, refactoring, and improvement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #602 in absence of a new design for the detail view, I reused the same design we're using for the Reader list view. This reuse is both in the UI and in code. We have a new
ReaderPostViewthat can be reused/embedded elsewhere in the future, e.g. as a way to view your own posts. This view can toggle between showing a summary, and showing the full content of the post. It works on iPhone and iPad, so this also improves the detail view on iPad.Along the way I did a bunch of refactoring to remove redundancies, move handlers out of views and into controllers, and general cleanup. The following additional issues will be resolved as a result: #416, #620, #645, #704.
Worth highlighting is a trick to preload images before they're visible. The approach (which @tomwitkin learned from another developer) is to use a
UITableViewthat is taller than the screen. The cost is additional maintenance of that modified height. We'll need to watch for bugs resulting from this trick, e.g. I had to fix the reblog form positioning.Video:
https://cloudup.com/cOvyJ9eWoou