Updated wpxmlrpc pod to include NSDateFormatter fix#724
Merged
astralbodies merged 2 commits intodevelopfrom Dec 6, 2013
Merged
Updated wpxmlrpc pod to include NSDateFormatter fix#724astralbodies merged 2 commits intodevelopfrom
astralbodies merged 2 commits intodevelopfrom
Conversation
CocoaLumberjack also got updated with this. Pointed the Podfile temporarily at the wpxmlrpc repo since Cocoapods Specs take a while for someone to merge the new podspec.
Contributor
|
Looks good, simple change, but one of those things that can take a lot of digging. I'm not intimately familiar with the specific POSIX change, but I trust you've investigated it deeply. If you trust me to trust you, then I think we're good to merge. What's with the 12k+ project changes? |
Contributor
Author
|
@mikejohnstn - thanks for reviewing 😄 Yup I've run into this in the past with locales changing the way NSDateFormatter format strings are interpreted. I'm going to submit a PR to the original project we based wpxmlrpc off of as well. The 12k+ changes were mostly due to Pods/Pods.xcodeproj/project.pbxproj since we haven't excluded CocoaPods from the repo. |
astralbodies
added a commit
that referenced
this pull request
Dec 6, 2013
#723 - Updated wpxmlrpc pod to include NSDateFormatter fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#723 - CocoaLumberjack also got updated with this. Pointed the Podfile temporarily at the wpxmlrpc repo since Cocoapods Specs take a while for someone to merge the new podspec.