Comment Actions: Fixed Font Size#7870
Merged
jleandroperez merged 3 commits intodevelopfrom Sep 29, 2017
Merged
Conversation
elibud
approved these changes
Sep 29, 2017
Contributor
elibud
left a comment
elibud
left a comment
There was a problem hiding this comment.
Going forward we do not want to hard code any font size into the app, but configure all the labels in a way that they would adjust their size according to dynamic type. However for Notifications we haven't done any work on a12y and I agree that the icons are a huge help, so I'm happy to approve this since it solves the problem and we can re-visit once we add proper a12y support to this area of the app.
Thanks for tackling this!
Contributor
Author
|
Agreed on everything up there @elibud!! thanks for the review! |
jleandroperez
deleted the
issue/7696-comment-action-dynamic-type-fixes
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
In this PR we're:
I'm opting towards a fixed point size, since that's exactly what happens with the TabBar: each action has an icon, so it really does not make any sense to break the UI. Each action is recognizable always.
Fixes #7696
To test:
Needs review: @elibud
Elisa, may i bug you with this one?
Thanks in advance!