Support new WordPressAuthenticator configuration and API methods#9714
Merged
mindgraffiti merged 19 commits intodevelopfrom Jul 11, 2018
Merged
Support new WordPressAuthenticator configuration and API methods#9714mindgraffiti merged 19 commits intodevelopfrom
mindgraffiti merged 19 commits intodevelopfrom
Conversation
…ranch of WordPressAuthenticator
nheagy
reviewed
Jul 6, 2018
| google_id = value | ||
| elsif k == "GOOGLE_LOGIN_SERVER_ID" | ||
| google_login_server = value | ||
| elsif k == "GOOGLE_AUTH_SCHEME" |
Contributor
There was a problem hiding this comment.
This should be GOOGLE_LOGIN_SCHEME_ID
…nScheme`" This reverts commit 4c42b16.
nheagy
suggested changes
Jul 9, 2018
Podfile
Outdated
| pod 'WordPress-Aztec-iOS', '1.0.0-beta.22' | ||
| pod 'WordPress-Editor-iOS', '1.0.0-beta.22' | ||
| pod 'WordPressUI', '1.0.4' | ||
| pod 'WordPressUI', '~> 1.0' |
Contributor
There was a problem hiding this comment.
This project doesn't use ~>. A a specific version is preferred (in this case 1.0.5?).
At least that's been the guideline before we broke out the separate pods…
| if ([WordPressAuthenticator isGoogleAuthURLWithUrl:url | ||
| sourceApplication:options[UIApplicationOpenURLOptionsSourceApplicationKey] | ||
| annotation:options[UIApplicationOpenURLOptionsAnnotationKey]]) { | ||
| if ([WordPressAuthenticator.shared handleGoogleAuthUrl:url sourceApplication:options[UIApplicationOpenURLOptionsSourceApplicationKey] annotation:options[UIApplicationOpenURLOptionsAnnotationKey]]) { |
Contributor
There was a problem hiding this comment.
Can we leave this broken onto multiple lines?
Contributor
Author
|
Tweaked the corner radius to match the same size as the original design. Per p1531239322000162-slack-C6H8C3G23, I'm going with the stronger shadow, offset height 2. Tweaked the font styling - I found the original inherited font settings for the titleLabel.
|
Contributor
Author
|
Hound is stuck. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This task allows WordPress-iOS to support the new configuration and API method changes found in wordpress-mobile/WordPressAuthenticator-iOS#10
To test login changes
pod installExpected Behavior
There should be no changes to the Login UI in WordPress-iOS. If there are, then a style definition was incorrectly applied or incorrectly defined in
WordPressAuthenticator-iOS.To test Aztec FancyAlert prompt changes
HACK2commitpod installExpected Behavior
The confirm email prompt buttons should remain styled the same as they were before.
Before changes:
After changes:
