Skip to content

Issues/facebook sharing#9872

Merged
aerych merged 10 commits intorelease/10.5.1from
issues/facebook-sharing
Jul 31, 2018
Merged

Issues/facebook sharing#9872
aerych merged 10 commits intorelease/10.5.1from
issues/facebook-sharing

Conversation

@aerych
Copy link
Contributor

@aerych aerych commented Jul 30, 2018

This PR is a version of #9867 that is branched from release/10.5 instead of develop, but otherwise the same commits and changes (sans some clean up around Podfile.lock). This is to facilitate pushing these changes as a hotfix for 10.5 and then merging back to develop more cleanly.

Previous PR description:

This is an 11th hour patch to address Facebook's privacy changes that affect publicize sharing to Facebook Profiles. As of August 1st, sharing to Facebook Profiles is no longer allowed.

This patch changes how Facebook sharing is handled so only sharing to Facebook Pages is supported. Attempting to share to a profile will result in a notice.
simulator screen shot - iphone 8 plus - 2018-07-28 at 15 50 48

An existing connection to a Facebook profile will show up as broken. On the detail page new messaging is shown.
simulator screen shot - iphone 8 plus - 2018-07-28 at 16 47 33

Clicking Learn More on either screen will open Safari to an FAQ. The destination is different for each button and should match the behavior in calypso.

To test:
You'll want a Facebook account to test with.

Scenario 1:
Attempt to set up a sharing connection to a Facebook profile. You should see the prompt that the connection could not be made because their are no pages.
Confirm clicking the Learn More button opens the support page in Safari.

Scenario 2:
Create a Facebook Page.
Attempt to set up sharing to Facebook again, and this time confirm that your newly created page is shown as an option. Go ahead and make the connection.

Scenario 3:
Edit SharingDetailViewController.m so mustDisconnectFacebook always returns true.
Navigate to the Facebook connection details screen and confirm that instead of a "Reconnect" option, you see a "Learn More" option and the appropriate footer text.
Confirm that the FAQ link opens in Safari.

cc @loremattei @ctarda @kwonye

@aerych aerych added the Sharing label Jul 30, 2018
@aerych aerych added this to the High Priority milestone Jul 30, 2018
@aerych aerych requested review from ctarda, kwonye and loremattei July 30, 2018 14:49
@wpmobilebot
Copy link
Contributor

1 Warning
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 Danger

Copy link
Contributor

@ctarda ctarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! It works exactly as described! :shipit: !

@aerych
Copy link
Contributor Author

aerych commented Jul 31, 2018

Woot! Thank you sir!

@aerych aerych merged commit 318d3be into release/10.5.1 Jul 31, 2018
@aerych aerych deleted the issues/facebook-sharing branch July 31, 2018 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants