Merged
Conversation
Contributor
Generated by 🚫 Danger |
ctarda
approved these changes
Jul 31, 2018
Contributor
ctarda
left a comment
There was a problem hiding this comment.
Yay! It works exactly as described!
!
Contributor
Author
|
Woot! Thank you sir! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a version of #9867 that is branched from
release/10.5instead ofdevelop, but otherwise the same commits and changes (sans some clean up aroundPodfile.lock). This is to facilitate pushing these changes as a hotfix for 10.5 and then merging back to develop more cleanly.Previous PR description:
This is an 11th hour patch to address Facebook's privacy changes that affect publicize sharing to Facebook Profiles. As of August 1st, sharing to Facebook Profiles is no longer allowed.
This patch changes how Facebook sharing is handled so only sharing to Facebook Pages is supported. Attempting to share to a profile will result in a notice.

An existing connection to a Facebook profile will show up as broken. On the detail page new messaging is shown.

Clicking
Learn Moreon either screen will open Safari to an FAQ. The destination is different for each button and should match the behavior in calypso.To test:
You'll want a Facebook account to test with.
Scenario 1:
Attempt to set up a sharing connection to a Facebook profile. You should see the prompt that the connection could not be made because their are no pages.
Confirm clicking the Learn More button opens the support page in Safari.
Scenario 2:
Create a Facebook Page.
Attempt to set up sharing to Facebook again, and this time confirm that your newly created page is shown as an option. Go ahead and make the connection.
Scenario 3:
Edit
SharingDetailViewController.msomustDisconnectFacebookalways returns true.Navigate to the Facebook connection details screen and confirm that instead of a "Reconnect" option, you see a "Learn More" option and the appropriate footer text.
Confirm that the FAQ link opens in Safari.
cc @loremattei @ctarda @kwonye