This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Hide site credential login button from Get Started screen after entering a WPCom site address#855
Merged
itsmeichigo merged 5 commits intotrunkfrom Aug 16, 2024
Merged
Conversation
…hether to display site credential button
4 tasks
Contributor
Author
|
Thanks Hafiz for the review! I've added 2 comments to bump the library version and will release the new version after this PR is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of woocommerce/woocommerce-ios#13622
Description
On WCiOS we support site credential login for self-hosted sites with JP connection. In a previous attempt to add the site credential login option, we accidentally enabled that option for WPCom sites. This option is not functional as it's impossible to log in to WPCom sites with site credentials, so this PR fixes this by hiding that option for WPCom sites.
Testing steps
Test the demo app to ensure that the credential login button is not available in the default case.
Additionally, follow the steps in woocommerce/woocommerce-ios#13623 to check the cases for WCiOS.
CHANGELOG.mdif necessary.