This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Re-implement RemoteMenu, RemoteMenuItem, and RemoteMenuLocation#557
Merged
crazytonyli merged 1 commit intotrunkfrom Dec 8, 2022
Merged
Re-implement RemoteMenu, RemoteMenuItem, and RemoteMenuLocation#557crazytonyli merged 1 commit intotrunkfrom
crazytonyli merged 1 commit intotrunkfrom
Conversation
mokagio
approved these changes
Dec 8, 2022
Contributor
mokagio
left a comment
mokagio
left a comment
There was a problem hiding this comment.
Neat little PR 👍
All those ? make me worry, but at least the compiler will make consumers deal with them...
When do you think it would be a good time to address all that nullability? Or, better question, is that something we should be worrying about at all (in the context of limited resources)
| @@ -0,0 +1,11 @@ | |||
| import Foundation | |||
|
|
|||
| @objcMembers public class RemoteMenu: NSObject { | |||
Contributor
There was a problem hiding this comment.
TIL about @objcMembers, to make all members of a Swift type available to Objective-C. Neat.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of re-implementing Objective-C in Swift.
versionin the.podspecfile.