This repository was archived by the owner on Sep 15, 2025. It is now read-only.
SPM Prep – Move sources and tests in Sources/ and Tests/ respectively#764
Merged
SPM Prep – Move sources and tests in Sources/ and Tests/ respectively#764
Sources/ and Tests/ respectively#764Conversation
This is to prepare the move to `Sources/` and `Tests/` in a way that keeps the existing structure intact, for ease of navigation.
This is to prepare the move to `Sources/` and `Tests/` in a way that keeps the existing structure intact, for ease of navigation.
This is to prepare the move to `Sources/` and `Tests/` in a way that keeps the existing structure intact, for ease of navigation.
This is to prepare the move to `Sources/` and `Tests/` in a way that keeps the existing structure intact, for ease of navigation.
This is to prepare the move to `Sources/` and `Tests/` in a way that keeps the existing structure intact, for ease of navigation.
This is to prepare the move to `Sources/` and `Tests/` in a way that keeps the existing structure intact, for ease of navigation.
This is to prepare the move to `Sources/` and `Tests/` in a way that keeps the existing structure intact, for ease of navigation.
This is to prepare the move to `Sources/` and `Tests/` in a way that keeps the existing structure intact, for ease of navigation.
This is to prepare the move to `Sources/` and `Tests/` in a way that keeps the existing structure intact, for ease of navigation.
This is to prepare the move to `Sources/` and `Tests/` in a way that keeps the existing structure intact, for ease of navigation.
This is to prepare the move to `Sources/` and `Tests/`. Many of the groups had only one file in them and there was no correspondence between them and the source code. By removing them, the job of changing the root to `Tests/` becomes simpler because we won't have to update references to "Group without Folder" that could not update automatically.
This is to prepare the move to `Sources/` and `Tests/` in a way that keeps the existing structure intact, for ease of navigation.
Collaborator
Generated by 🚫 Danger |
This required fixing the location of the `WPKitLogging*` files, which were public in the project but for some reason in the `Private/` folder and therefore considered private by CocoaPods (failing the bulid).
mokagio
force-pushed
the
mokagio/sources-and-tests-folders
branch
2 times, most recently
from
b422150 to
fce2b0d
Compare
2 tasks
mokagio
force-pushed
the
mokagio/sources-and-tests-folders
branch
from
fce2b0d to
3049fe5
Compare
mokagio
commented
Mar 25, 2024
| PODFILE CHECKSUM: 64af6d71574c7a92d01a9446aa874e066917ebe5 | ||
|
|
||
| COCOAPODS: 1.14.3 | ||
| COCOAPODS: 1.15.2 |
Contributor
Author
There was a problem hiding this comment.
I updated it as a preliminary, cover-all-bases, step before looking into a spec validation issue I incurred.
mokagio
commented
Mar 25, 2024
| @@ -1298,13 +1298,11 @@ | |||
| AB49D0B225D1B4D80084905B /* post-likes-failure.json */ = {isa = PBXFileReference; lastKnownFileType = text.json; path = "post-likes-failure.json"; sourceTree = "<group>"; }; | |||
| ABD95B7E25DD6C4B00735BEE /* CommentServiceRemoteRESTLikesTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CommentServiceRemoteRESTLikesTests.swift; sourceTree = "<group>"; }; | |||
| ABD95B8425DD6DA200735BEE /* comment-likes-success.json */ = {isa = PBXFileReference; lastKnownFileType = text.json; path = "comment-likes-success.json"; sourceTree = "<group>"; }; | |||
| B56D96B0202C9B7500485233 /* WordPressUI.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; path = WordPressUI.framework; sourceTree = BUILT_PRODUCTS_DIR; }; | |||
Contributor
Author
There was a problem hiding this comment.
👀 👀 👀
What was this doing in here? A leftover from a long time ago when WordPressUI was part of the project?
mokagio
commented
Mar 25, 2024
| s.source_files = 'WordPressKit/**/*.{h,m,swift}' | ||
| s.private_header_files = 'WordPressKit/Private/*.h' | ||
| s.header_dir = 'WordPressKit' | ||
| s.source_files = 'Sources/**/*.{h,m,swift}' |
Contributor
Author
There was a problem hiding this comment.
I could have made this Sources/WordPressKit/*.{h,m,swift} but I thought I'd leave it looser for the moment. I'm not sure how/if to sort how subspecs as well as subpackages.
crazytonyli
approved these changes
Mar 26, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it says in the title. This PR only moved files but required a couple of adjustments in the Xcode project :
WPKitLogging-files out of thePrivatefolder. The.hin particular is public in the project, but having it in that folder resulted in a validation failure at the CocoaPods level.Testing Details
See CI.
CHANGELOG.mdif necessary. — N.A.