This repository was archived by the owner on Jun 4, 2025. It is now read-only.
Move renderBackgroundImage() method out of FancyButton and into UIImage+Assets extension#8
Merged
mindgraffiti merged 4 commits intodevelopfrom Jul 3, 2018
Merged
Conversation
…`, move into UIImage+Assets extension
jleandroperez
suggested changes
Jul 3, 2018
| public static let backgroundShadowOffset = CGSize(width: 0, height: 1) | ||
| public static let backgroundShadowBlurRadius = CGFloat(0) | ||
| public static let contentInsets = UIEdgeInsets(top: 12, left: 20, bottom: 12, right: 20) | ||
| } |
Contributor
There was a problem hiding this comment.
Can we perhaps move these metrics back to FancyButton?. Reasoning is: they're set this way, because of that's what FancyButton requires. (You can just remove the default parameter assignments from the API here, and just wire them in the FancyButton code)
Contributor
Author
There was a problem hiding this comment.
Renamed to DefaultRenderMetrics
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the background image rendering method from FancyButton and adds it to the UIImage+Assets extension. It will be used in WordPressAuthenticator-iOS.
To Test
Change the WordPressUI pod to point to the new background image rendering extension branch
pod 'WordPressUI', :git => 'https://github.com/wordpress-mobile/WordPressUI-iOS.git', :branch => 'feature/extension-render-bg-image'This change helps support the implementation of a new feature in WordPressAuthenticator-iOS, NUXButton configurable using UIAppearance
cc: @jleandroperez