Skip to content

Release 1.97.1#5873

Merged
dcalhoun merged 8 commits intotrunkfrom
release/1.97.1
Jun 20, 2023
Merged

Release 1.97.1#5873
dcalhoun merged 8 commits intotrunkfrom
release/1.97.1

Conversation

@fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Jun 16, 2023

Release for Gutenberg Mobile 1.97.1

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Fix crash when using the delete key to remove a single button

Ensure text input field is not editable when Bottom sheet cell is disabled

Test plan

Once the installable builds of the main apps are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
  • Bundle package of the release is updated.

@fluiddot
Copy link
Contributor Author

@fluiddot
Copy link
Contributor Author

@fluiddot fluiddot marked this pull request as ready for review June 16, 2023 14:23
@fluiddot
Copy link
Contributor Author

fluiddot commented Jun 16, 2023

🟢 Writing Flow checklist (Android)

Build: jetpack-prototype-build-pr18611-b04e536.apk
Device: Samsung Galaxy S20 FE 5G

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

👀 Issues

Found a couple of non-regression issues:

@fluiddot
Copy link
Contributor Author

fluiddot commented Jun 16, 2023

🟢 Writing Flow checklist (iOS)

Build: jetpack-installable-builds #5043
Device: iPhone 11 (iOS 15.4.1)

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@geriux geriux self-requested a review June 16, 2023 14:59
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I've smoke tested the changes using the test builds on both iOS and Android 🚀

@dcalhoun dcalhoun enabled auto-merge June 16, 2023 19:11
@dcalhoun dcalhoun merged commit e0de0ad into trunk Jun 20, 2023
@dcalhoun dcalhoun deleted the release/1.97.1 branch June 20, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants