This repository was archived by the owner on Mar 7, 2025. It is now read-only.
Merged
Conversation
… config to package code from example's folder
…mands to clean and clean:install
…droid and future ios example
… remove activities and fragments from the library
…ld ReactAztecText and ReactAztecView references
…bile/react-native-aztec into issue/5-project-restructure
…press-mobile/react-native-aztec into issue/5-project-restructure
maxme
reviewed
Apr 16, 2018
| @@ -45,7 +45,7 @@ public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle sa | |||
| ReactRootView reactRootView = new ReactRootView(getContext()); | |||
| Bundle RNProps = new Bundle(); | |||
| RNProps.putString("text", EXAMPLE); | |||
Contributor
There was a problem hiding this comment.
I'm not sure why we have this on the Java side. Should we set the text from the js example file instead (example/App.js)?
Contributor
There was a problem hiding this comment.
I agree, we should set the content from JS at this point of the project.
Contributor
|
Looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5
This PR brings the new library structure as defined and proposed by @maxme following the https://github.com/wordpress-mobile/react-native-recyclerview-list project
Thank you @maxme for the guidance and plumbing work
cc @daniloercoli @maxme