Deprecate ios_final_tag and ios_clear_intermediate_tags#471
Merged
Conversation
…os_final_tag actions
…tion descriptions
4 tasks
spencertransier
approved these changes
May 9, 2023
Contributor
spencertransier
left a comment
spencertransier
left a comment
There was a problem hiding this comment.
Looks good! Just a minor spelling typo, but I think it's fine since it was in the original action and this is being deprecated anyway.
I confirmed that everything you added appears correctly in Fastlane:
And the actions correctly ask for confirmation before proceeding:
|
|
||
| def self.description | ||
| 'Finalize a relasae' | ||
| '(DEPRECATED) Finalize a relasae' |
Contributor
There was a problem hiding this comment.
Suggested change
| '(DEPRECATED) Finalize a relasae' | |
| '(DEPRECATED) Finalize a release' |
Contributor
Author
There was a problem hiding this comment.
I was going to apply the suggestion but the PR is auto-merged. Sorry about that @spencertransier.
Thank you for reviewing the PR 🙇♂️
oguzkocer
deleted the
deprecate/ios_final_tag_and_ios_clear_intermediate_tags
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
This PR deprecates
ios_final_tag&ios_clear_intermediate_tagsactions. We don't believe these actions are used anymore, but just to be sure, we wanted to deprecate them first.In order to deprecate the actions, here is a list of changes I've made:
:deprecatedcategorydeprecated_notes(DEPRECATED)prefix to thedetails&descriptionof each actionHopefully this ^ is the correct approach to deprecate these actions. Please let me know if I missed anything or if you have any suggestions.
Checklist before requesting a review
bundle exec rubocopto test for code style violations and recommendationsspecs/*_spec.rb) if applicablebundle exec rspecto run the whole test suite and ensure all your tests passCHANGELOG.mdfile to describe your changes under the approprioate existing###subsection of the existing## Trunksection.