[Tooling] Update and Modernize CI pipeline#677
Merged
AliSoftware merged 3 commits intotrunkfrom Dec 3, 2025
Merged
Conversation
b14549d to
15f971d
Compare
mokagio
reviewed
Dec 3, 2025
| export IMAGE_ID="xcode-26.1.1" | ||
| export CI_TOOLKIT="automattic/a8c-ci-toolkit#5.7.0" | ||
| export DOCKER_PLUGIN="docker#v5.13.0" | ||
| export RUBY_VERSION="3.2.2" |
Contributor
There was a problem hiding this comment.
Suggested change
| export RUBY_VERSION="3.2.2" | |
| export RUBY_VERSION="$(cat .ruby-version)" |
That's how we do it in other repos that have .xcode-version, but thinking about it I don't like how it assumes that the script runs (is sourced) from the project's root. Should use BASH_SOURCE[0] appropriately (which I don't remember off the top of my head).
Contributor
There was a problem hiding this comment.
LLM to the rescue:
Suggested change
| export RUBY_VERSION="3.2.2" | |
| SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" | |
| export RUBY_VERSION="$(cat "$SCRIPT_DIR/.ruby-version")" |
Contributor
There was a problem hiding this comment.
@copilot open a PR to implement the suggestion I left above, thanks.
Contributor
mokagio
approved these changes
Dec 3, 2025
Contributor
mokagio
left a comment
There was a problem hiding this comment.
Nice to shake the rust off this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What does it do?
shared-pipeline-varsfor DRY-ing common values used in our pipeline file (instead of relying on YAML anchors)IMAGE_IDXcode VM used from the very old16.1to the latest26.1.1imageci-toolkitanddockerBuildkite plugins to more recent versionChecklist before requesting a review
bundle exec rubocopto test for code style violations and recommendations.Add Unit Tests (akaspecs/*_spec.rb) if applicable.bundle exec rspecto run the whole test suite and ensure all your tests pass.CHANGELOG.mdfile to describe your changes under the appropriate existing###subsection of the existing## Trunksection.If applicable, add an entry in theMIGRATION.mdfile to describe how the changes will affect the migration from the previous major version and what the clients will need to change and consider.