fixing the device flag#22
Merged
workinghard merged 1 commit intoworkinghard:masterfrom Jan 9, 2020
Merged
Conversation
workinghard
reviewed
Jan 1, 2020
Owner
workinghard
left a comment
workinghard
left a comment
There was a problem hiding this comment.
Please explain/comment why you’re checking in Line 340 for „joyFD == -1“. It‘s not fully clear to me.
|
This was the only way to know that a device was not already set up to be watched. Without it, it would watch the last device found |
fixing the device flag fixing the device flag fixing the device flag fixing the device flag fixing the device flag fix listening fix listening fix listening fix listening fix listening fix listening fix listening x x git commit -q -m x
workinghard
approved these changes
Jan 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last found device was always being the one watched, regardless if a device was specified. This defaults to the first found if the specified device is not found.