Skip to content

provekit/common/src/witness/witness_generator: serializes the ABI as a json string. Something like CBOR might be better. #163

@recmo

Description

@recmo

On 2025-08-29 in 2a57572 “Merge pull request #153 from worldfnd/px/refactor”:

serializes the ABI as a json string. Something like CBOR might be better.

#[derive(Clone, Debug, Serialize, Deserialize)]
pub struct NoirWitnessGenerator {
    // Note: Abi uses an [internally tagged] enum format in Serde, which is not compatible
    // with some schemaless formats like Postcard.
    // [internally-tagged]: https://serde.rs/enum-representations.html
    // TODO: serializes the ABI as a json string. Something like CBOR might be better.
    #[serde(with = "serde_jsonify")]
    pub abi: Abi,

    /// ACIR witness index to R1CS witness index
    /// Index zero is reserved for constant one, so we can use `NonZeroU32`

From provekit/common/src/witness/witness_generator.rs:15

Metadata

Metadata

Assignees

No one assigned

    Labels

    to doTo do comments in codetracker🤖 issue managed by tracker bot

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions