Fix #38 Images that should be pushed but not kept are now deleted#109
Open
Ardesco wants to merge 2 commits intowouterd:masterfrom
Open
Fix #38 Images that should be pushed but not kept are now deleted#109Ardesco wants to merge 2 commits intowouterd:masterfrom
Ardesco wants to merge 2 commits intowouterd:masterfrom
Conversation
Owner
|
Hi Mike, Thanks for the PR. Actually, you can share state between Mojos, via the PluginContext. For the rest, this looks great. :) |
Contributor
Author
|
Close, it's Mark :) DOH! I've been looking at this the wrong way. I didn't push stuff up into the AbstractDockerMojo because I didn't want to cause a conflict between What I should have done is just define a list in AbstractDockerMojo instead of loading the data I care about sharing into a property. I'll refactor it on the train on the way home tonight. |
Contributor
Author
|
All done now, let me know if there's anything else outstanding. |
…tractDockerMojo instead of passing around a maven property.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no good way to share information between MOJO's so I've used a maven property to pass over a comma separated list of image IDs.