Skip to content

Don't warn about .htaccess file when --include-root is used #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielbachhuber merged 3 commits into from
Jun 1, 2023
Merged

Don't warn about .htaccess file when --include-root is used #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3865300
Don't warn about .htaccess file when --include-root is used
paulschreiber May 31, 2023
ad0768b
add .htaccess file to tests
paulschreiber May 31, 2023
9209171
update test output for htaccess
paulschreiber May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions features/checksum-core.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,10 @@ Feature: Validate checksums for WordPress install

Scenario: Verify core checksums when extra files are included in WordPress root and --include-root is passed
Given a WP install
And a .htaccess file:
"""
# BEGIN WordPress
"""
And a extra-file.php file:
"""
hello world
Expand All @@ -169,6 +173,10 @@ Feature: Validate checksums for WordPress install
"""
Warning: File should not exist: extra-file.php
"""
And STDERR should not contain:
"""
Warning: File should not exist: .htaccess
"""
And STDERR should not contain:
"""
Warning: File should not exist: wp-content/unknown-file.php
Expand Down
2 changes: 1 addition & 1 deletion src/Checksum_Core_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ public function __invoke( $args, $assoc_args ) {
*/
protected function filter_file( $filepath ) {
if ( true === $this->include_root ) {
return ( 1 !== preg_match( '/^(wp-config\.php$|wp-content\/)/', $filepath ) );
return ( 1 !== preg_match( '/^(\.htaccess$|wp-config\.php$|wp-content\/)/', $filepath ) );
}

return ( 0 === strpos( $filepath, 'wp-admin/' )
Expand Down