Skip to content

Plugin Checksums: Don't check missing files #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schlessera merged 2 commits into from
Nov 1, 2024
Merged

Plugin Checksums: Don't check missing files #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62066bd
Don't check for missing files, current checksums don't offer that fun…
dd32 Oct 22, 2024
dd2bbb6
Remove test
dd32 Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions features/checksum-plugin.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,6 @@ Feature: Validate checksums for WordPress plugins
"""
And STDERR should be empty

When I try `wp plugin verify-checksums duplicate-post --format=json --version=3.2.2`
Then the return code should be 1
And STDOUT should contain:
"""
"plugin_name":"duplicate-post","file":"duplicate-post-jetpack.php","message":"File is missing"
"""
And STDERR should be:
"""
Error: No plugins verified (1 failed).
"""

Scenario: Modified plugin doesn't verify
Given a WP install

Expand All @@ -50,19 +39,6 @@ Feature: Validate checksums for WordPress plugins
Error: No plugins verified (1 failed).
"""

When I run `rm wp-content/plugins/duplicate-post/duplicate-post.css`
Then STDERR should be empty

When I try `wp plugin verify-checksums duplicate-post --format=json`
Then STDOUT should contain:
"""
"plugin_name":"duplicate-post","file":"duplicate-post.css","message":"File is missing"
"""
And STDERR should be:
"""
Error: No plugins verified (1 failed).
"""

When I run `touch wp-content/plugins/duplicate-post/additional-file.php`
Then STDERR should be empty

Expand Down
6 changes: 0 additions & 6 deletions src/Checksum_Plugin_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,12 +133,6 @@ public function __invoke( $args, $assoc_args ) {

$files = $this->get_plugin_files( $plugin->file );

foreach ( $checksums as $file => $checksum_array ) {
if ( ! in_array( $file, $files, true ) ) {
$this->add_error( $plugin->name, $file, 'File is missing' );
}
}

foreach ( $files as $file ) {
if ( ! array_key_exists( $file, $checksums ) ) {
$this->add_error( $plugin->name, $file, 'File was added' );
Expand Down