Skip to content

[Refresh] Respect cron locks when running crons#82

Closed
johnbillion wants to merge 7325 commits into
wp-cli:masterfrom
johnbillion:27-doing-cron
Closed

[Refresh] Respect cron locks when running crons#82
johnbillion wants to merge 7325 commits into
wp-cli:masterfrom
johnbillion:27-doing-cron

Conversation

@johnbillion
Copy link
Copy Markdown
Contributor

@johnbillion johnbillion commented Aug 11, 2022 •
edited
Loading

This refreshes #38 and excludes the unrelated code quality changes.

Fixes #27.

danielbachhuber and others added 30 commits February 7, 2017 09:27
@danielbachhuber
Ensure version_tags() always returns array, which is expected
02576d9
@danielbachhuber
Use private key delivered by Travis, instead of stored in project
fe4b0fd
@danielbachhuber
Disable test suite for purposes of testing deployment
53f80e8
@danielbachhuber
Disable branch verification too for
a9078b1 
53f80e8
@danielbachhuber
Use Travis' SSH key instead of our own
d79db82
@danielbachhuber
See what's in SSH dir
d85bac9
@danielbachhuber
Revert "See what's in SSH dir"
f8631e3 
This reverts commit d85bac9.
@danielbachhuber
Revert "Use Travis' SSH key instead of our own"
ec7041c 
This reverts commit d79db82.
@danielbachhuber
Test the private key so we can see what's up
a09a463
@danielbachhuber
Ensure the environment variable is evaluated
4ee305b
@danielbachhuber
Let's see what this variable is
f2047cf
@danielbachhuber
Use base64-encoded ssh key
041a9ed
@danielbachhuber
Properly pass environment variable to file
9821928
@danielbachhuber
Remove code that exposes private key
0653ac3
@danielbachhuber
Revert debugging comments
f985ef3
@danielbachhuber
DEPLOY_BRANCH needs to be 'master'
bd0d8cb
@danielbachhuber
Merge pull request #3799 from wp-cli/test-improvements
509732c 
General improvements to the build process
@danielbachhuber
Failing test case for #3794
3ff6abf
@danielbachhuber
Escape prefix when listing all tables with prefix
85a5125
@danielbachhuber
Assign a new variable, so later use of $prefix isn't clobbered
97030bb
@danielbachhuber
Merge pull request #3801 from wp-cli/3794-escape-prefix
05306fe 
Escape prefix when listing all tables with prefix
@miya0001
fixed bug #3790
24aec1d
@miya0001
added to check stderr
5de154c
@miya0001
to be same with another ommand
d111487
@miya0001
add tests for one or more plugin is updated
add391a
@danielbachhuber
Merge pull request #3803 from miya0001/bug-fix-on-plugin-update
d319bf0 
Display correct error when plugin update fails to update plugins
@danielbachhuber
Update Composer dependencies (2/15/2017)
014719e 
```
Loading composer repositories with package information
Updating dependencies (including require-dev)
  - Removing symfony/finder (v2.8.16)
  - Installing symfony/finder (v2.8.17)
    Loading from cache

  - Removing symfony/yaml (v2.8.16)
  - Installing symfony/yaml (v2.8.17)
    Downloading: 100%

  - Removing symfony/filesystem (v2.8.16)
  - Installing symfony/filesystem (v2.8.17)
    Loading from cache

  - Removing symfony/config (v2.8.16)
  - Installing symfony/config (v2.8.17)
    Downloading: 100%

  - Removing symfony/debug (v2.8.16)
  - Installing symfony/debug (v2.8.17)
    Downloading: 100%

  - Removing symfony/console (v2.8.16)
  - Installing symfony/console (v2.8.17)
    Downloading: 100%

  - Removing symfony/dependency-injection (v2.8.16)
  - Installing symfony/dependency-injection (v2.8.17)
    Downloading: 100%

  - Removing symfony/event-dispatcher (v2.8.16)
  - Installing symfony/event-dispatcher (v2.8.17)
    Loading from cache

  - Removing symfony/process (v2.8.16)
  - Installing symfony/process (v2.8.17)
    Downloading: 100%

  - Removing symfony/translation (v2.8.16)
  - Installing symfony/translation (v2.8.17)
    Downloading: 100%

  - Removing wp-cli/php-cli-tools (v0.11.1)
  - Installing wp-cli/php-cli-tools (v0.11.2)
    Downloading: 100%

Writing lock file
Generating autoload files
```
@danielbachhuber
Merge pull request #3809 from wp-cli/update-deps-2017-02-15
827fb70 
Update Composer dependencies (2/15/2017)
@schlessera
Remove XDebug from PHP runtime within Travis CI environment.
42257c4 
Uses the snippet from the Travis CI Docs found here:

[https://docs.travis-ci.com/user/languages/php#Disabling-preinstalled-PHP-extensions](https://docs.travis-ci.com/user/languages/php#Disabling-preinstalled-PHP-extensions)

Fixes #3812
@danielbachhuber
Merge pull request #3813 from schlessera/3812-disable-xdebug-in-travis
f900a4b 
Remove XDebug from PHP runtime within Travis CI environment.
wojsmol and others added 20 commits December 3, 2021 21:07
@wojsmol
Add php 8.1 support
2f2d6e6
@schlessera
Merge pull request wp-cli#77 from wojsmol/fix/php8.1-compat
bfa120b
@schlessera
Update file(s) from wp-cli/.github
6e98d33
@schlessera
Adapt feature test to use HTTPS with example.com
970817d
@schlessera
Merge pull request wp-cli#78 from wp-cli/fix/use-https-example-com
829586b
@schlessera
Update file(s) from wp-cli/.github
f9e965e
@schlessera
Update file(s) from wp-cli/.github
f0f8537
@schlessera
Update file(s) from wp-cli/.github
4658d0c
@schlessera
Update file(s) from wp-cli/.github
23a22ba
@johnbillion @schlessera
Promote a non-200 response from the cron spawn test to an error rathe…
1579c40 
…r than a warning.
@johnbillion @schlessera
Remove the feature test for the cron spawn test because it sends a re…
dfa341e 
…quest to `example.com`
@schlessera
Allow Composer plugins to run
5191037
@schlessera
Adapt anchor text
d9f1f04
@schlessera
Add cron testing
6a34611
@schlessera
Merge pull request wp-cli#66 from johnbillion/fix/cron-test
bb9fd96
@schlessera
Update file(s) from wp-cli/.github
69c0537
@schlessera
Update file(s) from wp-cli/.github
3ce9f8e
@schlessera @johnbillion
First try at fixing cron locks
013b3cf
@schlessera @johnbillion
Re-add missing logic
75cf160
@schlessera @johnbillion
Improve code quality
14c1634
@johnbillion
Copy link
Copy Markdown
Contributor Author

johnbillion commented Aug 12, 2022

Not sure what's up with the functional tests. Getting many failures with the wp-config.php transformation:

001 Scenario: Scheduling and then deleting an event                                                                                                          # features/cron.feature:8
      And I run `wp config set DISABLE_WP_CRON false --raw --type=constant --anchor='// ** MySQL settings - You can get this info from your web host ** //'` # features/cron.feature:5
        $ wp config set DISABLE_WP_CRON false --raw --type=constant --anchor='// ** MySQL settings - You can get this info from your web host ** //'
        
        Error: Could not process the 'wp-config.php' transformation.
        Reason: Unable to locate placement anchor.
        cwd: /tmp/wp-cli-test-run--62f596dd0d4771.02058781/
        run time: 0.21218585968018
        exit status: 1 (RuntimeException)

@wojsmol
Copy link
Copy Markdown
Contributor

wojsmol commented Aug 12, 2022

@johnbillion This is because you are using --anchor='// ** MySQL settings - You can get this info from your web host ** // witch don't match wp-config.php generated with WP-CLI https://github.com/wp-cli/config-command/blob/f5960976af5b0a6f2f19a1bb9762d84494038759/templates/wp-config.mustache#L22

@johnbillion
Copy link
Copy Markdown
Contributor Author

johnbillion commented Aug 12, 2022

Right but that anchor hasn't changed in this PR

@johnbillion
Copy link
Copy Markdown
Contributor Author

johnbillion commented Aug 12, 2022

Oh I beg your pardon, yes it has. Hmmmm.

wojsmol
wojsmol reviewed Aug 12, 2022
View reviewed changes
Comment thread features/cron.feature Outdated
@wojsmol
Copy link
Copy Markdown
Contributor

wojsmol commented Aug 12, 2022

Template used to generate wp-config.php was updated in wp-cli/config-command#139

@johnbillion @wojsmol
Update features/cron.feature
0ed8b36 
Co-authored-by: Wojciech Smoliński <wojsmol@wp.pl>
@danielbachhuber
Copy link
Copy Markdown
Member

danielbachhuber commented Nov 18, 2022

Proceeding with wp-cli/wp-cli#5594 for this repository. I've captured this PR to https://gist.github.com/danielbachhuber/800870993ce975f7e775219180cc37fa in case this PR is auto-closed or broken in some way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@wojsmol wojsmol wojsmol left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone