Skip to content

Ensure post attachment meta is exported correctly #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schlessera merged 1 commit into from
Jul 25, 2021
Merged

Ensure post attachment meta is exported correctly #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
"wp-cli/db-command": "^1.3 || ^2",
"wp-cli/entity-command": "^1.3 || ^2",
"wp-cli/extension-command": "^1.2 || ^2",
"wp-cli/media-command": "^1 || ^2",
"wp-cli/import-command": "^1 || ^2",
"wp-cli/wp-cli-tests": "^3.0.11"
},
Expand Down
56 changes: 34 additions & 22 deletions features/export.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -736,52 +736,36 @@ Feature: Export content.

Scenario: Export individual post with attachments
Given a WP install

When I run `wp plugin install wordpress-importer --activate`
Then STDOUT should contain:
"""
Success:
"""
And I run `wp plugin install wordpress-importer --activate`
And I run `wp site empty --yes`

When I run `wp post generate --count=10`
And I run `wp post list --format=count`
Then STDOUT should be:
"""
11
10
"""

When I run `wp post create --post_title='Post with attachment to export' --porcelain`
Then STDOUT should be a number
And save STDOUT as {EXPORT_ATTACHMENT_POST_ID}

When I run `wp post create --post_type=attachment --porcelain`
When I run `wp media import 'http://wp-cli.org/behat-data/codeispoetry.png' --post_id={EXPORT_ATTACHMENT_POST_ID} --porcelain`
Then STDOUT should be a number
And save STDOUT as {EXPORT_ATTACHMENT_ID}

When I run `wp post update {EXPORT_ATTACHMENT_ID} --post_parent={EXPORT_ATTACHMENT_POST_ID} --porcelain`
Then STDOUT should contain:
"""
Success: Updated post {EXPORT_ATTACHMENT_ID}
"""

When I run `wp post create --post_title='Post with attachment to ignore' --porcelain`
Then STDOUT should be a number
And save STDOUT as {IGNORE_ATTACHMENT_POST_ID}

When I run `wp post create --post_type=attachment --porcelain`
When I run `wp media import 'http://wp-cli.org/behat-data/white-150-square.jpg' --post_id={IGNORE_ATTACHMENT_POST_ID} --porcelain`
Then STDOUT should be a number
And save STDOUT as {IGNORE_ATTACHMENT_ID}

When I run `wp post update {IGNORE_ATTACHMENT_ID} --post_parent={IGNORE_ATTACHMENT_POST_ID} --porcelain`
Then STDOUT should contain:
"""
Success: Updated post {IGNORE_ATTACHMENT_ID}
"""

When I run `wp post list --post_type=post --format=count`
Then STDOUT should be:
"""
13
12
"""

When I run `wp post list --post_type=attachment --format=count`
Expand All @@ -804,6 +788,26 @@ Feature: Export content.
"""
<wp:post_id>{EXPORT_ATTACHMENT_ID}</wp:post_id>
"""
And the {EXPORT_FILE} file should contain:
"""
<wp:meta_key>_wp_attachment_metadata</wp:meta_key>
"""
And the {EXPORT_FILE} file should contain:
"""
codeispoetry.png";s:5:"sizes"
"""
And the {EXPORT_FILE} file should contain:
"""
<wp:meta_key>_wp_attached_file</wp:meta_key>
"""
And the {EXPORT_FILE} file should contain:
"""
codeispoetry.png]]></wp:meta_value>
"""
And the {EXPORT_FILE} file should not contain:
"""
<wp:meta_key>_edit_lock</wp:meta_key>
"""
And the {EXPORT_FILE} file should not contain:
"""
<wp:post_id>{IGNORE_ATTACHMENT_POST_ID}</wp:post_id>
Expand All @@ -812,6 +816,14 @@ Feature: Export content.
"""
<wp:post_id>{IGNORE_ATTACHMENT_ID}</wp:post_id>
"""
And the {EXPORT_FILE} file should not contain:
"""
white-150-square.jpg]]></wp:meta_value>
"""
And the {EXPORT_FILE} file should not contain:
"""
white-150-square.jpg";s:5:"sizes"
"""

Scenario: Export categories, tags and terms
Given a WP install
Expand Down
6 changes: 3 additions & 3 deletions src/WP_Export_Query.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,11 +387,11 @@ private static function get_meta_for_post( $post ) {
$meta_for_export = [];
$meta_from_db = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $wpdb->postmeta WHERE post_id = %d", $post->ID ) );
foreach ( $meta_from_db as $meta ) {
// phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound -- Calling native WordPress hook.
if ( apply_filters( 'wxr_export_skip_postmeta', false, $meta->meta_key, $meta ) ) {
if ( '_edit_lock' === $meta->meta_key ) {
continue;
}
if ( in_array( $meta->meta_key, [ '_edit_lock', '_wp_attachment_metadata', '_wp_attached_file' ], true ) ) {
// phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound -- Calling native WordPress hook.
if ( apply_filters( 'wxr_export_skip_postmeta', false, $meta->meta_key, $meta ) ) {
continue;
}
$meta_for_export[] = $meta;
Expand Down