Packages installed from git where the git user has capital letters don't show up in `package list`

[javorszky]

I've created an example command here: https://github.com/CapitalWPCLI/examplecommand

To reproduce:

1. wp package install git@github.com:CapitalWPCLI/examplecommand.git
2. wp package list, see that it is not in the list
3. go and look at the composer.json file in ~/wp-cli/packages folder. See that the package's key is the github user : repository
4. because of the code that lists the packages matches the package id (all lowercase) with what's in the composer json, it will not be matched.

Environment

$ uname -a
Darwin GaborrMBP 17.0.0 Darwin Kernel Version 17.0.0: Thu Aug 24 21:48:19 PDT 2017; root:xnu-4570.1.46~2/RELEASE_X86_64 x86_64

$ which -a php
/usr/local/bin/php
/usr/bin/php

$ php -v
PHP 7.1.10 (cli) (built: Oct  6 2017 01:08:53) ( NTS )
Copyright (c) 1997-2017 The PHP Group
Zend Engine v3.1.0, Copyright (c) 1998-2017 Zend Technologies
    with Xdebug v2.5.5, Copyright (c) 2002-2017, by Derick Rethans

no suhosin

Which version of WordPress
none, not specific

$ which -a wp
stat $(which wp)
/usr/local/bin/wp
16777220 56521130 -rwxr-xr-x 1 javorszky staff 0 4292472 "Oct 15 13:03:17 2017" "Sep 10 17:58:46 2017" "Sep 27 16:50:55 2017" "Sep 10 17:58:44 2017" 4194304 8384 0 /usr/local/bin/wp

Hope this is enough information.

[javorszky]

From the looks of it, this piece of code should handle the mismatch:

https://github.com/wp-cli/package-command/blob/master/src/Package_Command.php#L221-L227

But for some reason doesn't.

[gitlost]

Thanks for the excellent example and diagnostics @javorszky.

this piece of code should handle the mismatch

Composer is doing strtolower()s all over the place for some reason so the package name gets "corrected" to its lowercase version.

A way around might be to do $installed_package_keys = array_map( 'strtolower', $installed_package_keys ); in get_installed_packages(), and also to lowercase the $package_name arg in get_installed_package_by_name() and (for the BC check only) get_package_by_shortened_identifier().

[javorszky]

I think the install script is wrong. It compares the package name in the composer.json in the repo with the name of the repo, and if the two don't match, it uses the name in the composer.json.

Or at least should. If you look in the composer.json of the example command, that one is all lowercase because composer complains otherwise.

Yet what does get installed / recorded is the repo name, so the comparison goes wrong there. I think. I don't have wpcli set up for dev on my computer, so can't double check this with debugging statements.

[gitlost]

I think the install script is wrong. It compares the package name in the composer.json in the repo with the name of the repo, and if the two don't match, it uses the name in the composer.json.

Ah maybe it shouldn't then. If I change that check to if ( strtolower( $package_name ) !== $package_name_on_repo ) { then things kind of work okay, ie the require etc keys in ~/wp.cli/packages/composer.json all have the non-lowercased name.

And with the strtolower() hacks mentioned earlier can uninstall okay as long as I specify the correct case.

The listing is wrongly in lowercase though.

[javorszky]

What I mean is that if the github is CapitalWPCLI/examplecommand, and the composer json has capitalwpcli/examplecommand as the name, it should save as capitalwpcli/examplecommand.

Currently it saves as CapitalWPCLI/examplecommand.

[javorszky]

To be fair, I expect the ~/.wp-cli/package/composer.json would have the name of the package as it's declared in the composer.json of the package.

[gitlost]

Okay, ta. It's very confusing and messy. I'll leave it to the Composer experts, of which I'm most definitely not. Related wp-cli/wp-cli#4232 and #31

[javorszky]

Okies. I summon @schlessera / @danielbachhuber to take a glance at this if they have a moment :)

[gitlost]

Mystery solved - just noticed the 4292472 in your stat of wp - that's the size of wp-cli 1.3.0 - and #31 is only in 1.4.0, so that's why the mixed case git user name is ending up in your composer.json, as it's not getting corrected by mismatch check in the lines you highlighted.

I'll add a test anyway to clarify this situation (for myself mostly, given the confusion I got myself into above).

[javorszky]

Ooh, okay. That makes sense! Thank you. An uh... sorry for not checking the versions! Should I leave this open until the tests are added?

[gitlost]

Hi, thanks for getting back. Please leave it open yes, as I've found out that there is an issue after all with mixed-case names with the current version, though not in your particular case (but when the name in composer.json is mixed-case anyway).

I'm going to do a PR very soon with a fix for that case, and also with tests for that case and your case. The tests will use your test example https://github.com/CapitalWPCLI/examplecommand if that's alright. Also if and when you have the time if you could confirm that updating to the latest wp-cli fixes your issue it'd be much appreciated.

[javorszky]

Will do! I'll keep an eye out for the new versions of wp-cli! Thank you for looking into this!