Replace SwiftLint workflow with SwiftFormat #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the SwiftLint-based code linting workflow with a SwiftFormat-based workflow for code formatting. The change simplifies the CI pipeline by removing linting checks and focusing solely on code formatting.
- Removes the existing SwiftLint workflow and replaces it with a new SwiftFormat workflow
- Updates README badge references to point to the new SwiftFormat workflow
- Removes SwiftLint installation and execution steps while keeping only SwiftFormat
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| README.md | Updates workflow badge references from SwiftLint to SwiftFormat |
| .github/workflows/wrkstrm-log-swiftlint.yml | Completely removes the SwiftLint workflow file |
| .github/workflows/wrkstrm-log-swiftformat.yml | Creates new SwiftFormat-only workflow without linting |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
| uses: maxim-lobanov/setup-xcode@v1 | ||
| if: matrix.os == 'macos-latest' || matrix.os == 'macos-15' || matrix.os == 'self-hosted' | ||
| with: | ||
| xcode-version: '16.4' |
There was a problem hiding this comment.
The Xcode setup step will never execute because the workflow only runs on ubuntu-latest, but the condition checks for macOS runners. This step should be removed or the matrix should include macOS runners.
Suggested change
| xcode-version: '16.4' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
swift format --configuration https://raw.githubusercontent.com/wrkstrm/configs/main/linting/.swift-format -i -r -p .(fails: Unable to read configuration)swiftlintswift testhttps://chatgpt.com/codex/tasks/task_e_689ee501b5ec83338764dcee5c3b556f