Skip to content

Updating link in README to noetic in order to compile#25

Merged
wsnewman merged 3 commits intowsnewman:noetic_develfrom
mfkenson:noetic_devel
Mar 14, 2022
Merged

Updating link in README to noetic in order to compile#25
wsnewman merged 3 commits intowsnewman:noetic_develfrom
mfkenson:noetic_devel

Conversation

@mfkenson
Copy link
Copy Markdown
Contributor

@mfkenson mfkenson commented Mar 8, 2022

  1. updating git repo in README.md
  2. fixing file paths in launch files

Copy link
Copy Markdown
Collaborator

@leegs leegs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these edits.

Comment thread README.md

This entire repository should be cloned to: ~/ros_ws/src (assuming your ros workspace is named "ros_ws" and resides within your home directory). To do so, navigate to ~/ros_ws/src from a terminal and enter:
`git clone https://github.com/wsnewman/learning_ros.git`
`git clone --recursive https://github.com/wsnewman/learning_ros.git`
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This edit will be accepted.

Comment thread README.md
`git clone --recursive https://github.com/wsnewman/learning_ros.git`
and also clone the external packages used with:
`git clone https://github.com/wsnewman/learning_ros_external_packages.git`
`git clone --recursive https://github.com/wsnewman/learning_ros_external_pkgs_noetic`
Copy link
Copy Markdown
Collaborator

@leegs leegs Mar 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repository will not exist. The learning_ros_external_pkgs repository is working with both Melodic and Noetic at this time. (At least is should be.) If the updated version does not work for Noetic, please submit an issue on that repository.

This edit will not be accepted as it will not be necessary.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry my mistake. The repo link should end with .git. However the recursive flag is necessary I believe.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leegs I tried the original https://github.com/wsnewman/learning_ros_external_packages but failed on both noetic and melodic, mainly due to missing baxter related packages.

My only successful catkin_make is on noetic after running commands below.

mkdir -p ~/ros_ws/src/
cd ~/ros_ws/src/
git clone --recursive https://github.com/wsnewman/learning_ros.git
git clone --recursive https://github.com/wsnewman/learning_ros_external_pkgs_noetic.git
cd ~/ros_ws/
rosdep install --from-paths src --ignore-src -r -y
sudo apt install ros-noetic-moveit
catkin_make

Copy link
Copy Markdown
Collaborator

@leegs leegs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the change for the "learning_ros_external_pkgs" line as it is being address separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants