Add support for JPT with Split-BBS, and JWT key generation via ARKG #751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emacs struggles with very long lines, making it very cumbersome to work with the file.
Without this, the subsequent commits will increase the size of the `index` chunk too far beyond the default limits, causing the build to fail: ``` dist/registerSW.js 0.15 kB dist/index.html 1.81 kB │ gzip: 0.65 kB dist/assets/cred-q9ZjtDZ6.png 144.18 kB dist/assets/index-C89oq9bN.css 43.66 kB │ gzip: 10.24 kB dist/assets/VerificationResult-CNHbgecd.js 0.35 kB │ gzip: 0.26 kB dist/assets/CredentialHistory-CoYs8f20.js 0.53 kB │ gzip: 0.35 kB dist/assets/History-DfaXvzkq.js 0.53 kB │ gzip: 0.35 kB dist/assets/NotFound-DBuO3A6l.js 1.11 kB │ gzip: 0.53 kB dist/assets/SendCredentials-CParQcUG.js 1.35 kB │ gzip: 0.78 kB dist/assets/DeletePopup-Cn7PTdlc.js 1.39 kB │ gzip: 0.69 kB dist/assets/HistoryList-jFe1o25d.js 2.23 kB │ gzip: 1.12 kB dist/assets/PinInput-BnZhB0W3.js 2.37 kB │ gzip: 1.18 kB dist/assets/LoginLayout-CWHGNvbD.js 2.40 kB │ gzip: 1.08 kB dist/assets/extractPresentations-s5wrsHOV.js 2.42 kB │ gzip: 1.11 kB dist/assets/index.esm-CM8ky46Q.js 2.55 kB │ gzip: 1.03 kB dist/assets/index.esm-CywRozxX.js 2.71 kB │ gzip: 0.90 kB dist/assets/HistoryDetail-C3i8QoLQ.js 2.87 kB │ gzip: 1.39 kB dist/assets/LoginState-WW7cMfQX.js 3.19 kB │ gzip: 1.40 kB dist/assets/PrivateRoute-Ct5IZDK0.js 3.58 kB │ gzip: 1.36 kB dist/assets/index.esm-B1qVhGT0.js 3.73 kB │ gzip: 1.65 kB dist/assets/AddCredentials-BHsCSvC2.js 4.45 kB │ gzip: 1.87 kB dist/assets/EntityListItem-CxM3wW_v.js 5.21 kB │ gzip: 1.96 kB dist/assets/Home-DIRKiQT9.js 5.31 kB │ gzip: 1.87 kB dist/assets/Login-WZs_vuPo.js 14.14 kB │ gzip: 4.37 kB dist/assets/Settings-BB6MAqrH.js 21.05 kB │ gzip: 5.62 kB dist/assets/Credential-BIJMN99y.js 29.45 kB │ gzip: 10.48 kB dist/assets/qr-scanner-worker.min-D85Z9gVD.js 43.95 kB │ gzip: 10.40 kB dist/assets/Layout-pVwQC_xI.js 120.39 kB │ gzip: 41.01 kB dist/assets/index-hzcpcnmk.js 3,195.95 kB │ gzip: 874.27 kB (!) Some chunks are larger than 500 kB after minification. Consider: - Using dynamic import() to code-split the application - Use build.rollupOptions.output.manualChunks to improve chunking: https://rollupjs.org/configuration-options/#output-manualchunks - Adjust chunk size limit for this warning via build.chunkSizeWarningLimit. ✓ built in 13.07s PWA v0.21.1 Building src/service-worker.js service worker ("es" format)... vite v6.1.1 building for production... ✓ 87 modules transformed. dist/service-worker.mjs 23.82 kB │ gzip: 7.90 kB ✓ built in 153ms error during build: Error: Configure "injectManifest.maximumFileSizeToCacheInBytes" to change the limit: the default value is 2 MiB. Check https://vite-pwa-org.netlify.app/guide/faq.html#missing-assets-from-sw-precache-manifest for more information. Assets exceeding the limit: - assets/index-hzcpcnmk.js is 3.21 MB, and won't be precached. [...<stack trace redacted>] error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. ```
This fixes possible issues with rotating the key immediately after creating it, where otherwise it wouldn't be possible to re-wrap private keys without first taking a detour through session storage to get `importMainKey` to add the "unwrapKey" usage.
Credential status indicators
In particular, the `keystore` module no longer needs to juggle a UI state machine with retry logic, and instead simply receives a callback to execute a WebAuthn ceremony. Retry logic is handled completely by the caller.
emlun
force-pushed
the
sign-extension-bbs
branch
from
d7f4a5e to
dff0c9d
Compare
Previously, any errors past the point of entering the name for the hardware key were not surfaced to the user. This was because the dialog was dismissed before completing the whole operation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
JPT support is largely a hack based on the JWT protocols. Essentially, I've copied the JWT things and replaced as little as possible with JPT equivalents where necessary. JPTs reuse the JWT VC metadata, masquerade as JWTs in the DCQL parsers and so on. The two are surprisingly compatible. 🙂