Skip to content

Credential status indicators fix: Check that credential format is 'dc+jpt' before treating it as such #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
smncd wants to merge 1 commit into
base: sign-extension-bbs
Choose a base branch
from
Open

Credential status indicators fix: Check that credential format is 'dc+jpt' before treating it as such #891

smncd wants to merge 1 commit into from

Conversation

@smncd
Copy link
Member

@smncd smncd commented Oct 8, 2025

Add a simple check to make sure that the credential that we're about to parse is actually of the correct type.

This fixes the following exception:

hook.js:608 TypeError: Cannot read properties of undefined (reading 'replace')
    at fromBase64Url (util.ts:136:22)
    at getCredentialStatusIndicators (CredentialStatusIndicatorsRibbon.tsx:42:55)
    at CredentialStatusIndicatorsRibbon (CredentialStatusIndicatorsRibbon.tsx:149:47)

@smncd smncd requested a review from emlun October 8, 2025 13:10
@smncd smncd requested a review from a team as a code owner October 8, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emlun emlun Awaiting requested review from emlun

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@smncd